Impose upper bound on pylint version #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasmuss
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Looks good! Added a minor fixup to the wording in the changelog. It's generally most useful to describe the effect of the change (restricting the pylint version) and the motivation (what was failing), rather than just the mechanical change (adding an upper bound). And then modified the commit message to describe the change (same reasoning) and to avoid referring to FPGAs in particular (since this isn't specific to the FPGA repos).
Pylint 2.5 errors if the package being checked is not installed. It is not clear whether this is an intentional change or not, so we are temporarily avoiding this version.
|
Oh one other thing, could you open an issue with pylint as well so that we have something to follow to see if there is any upstream resolution to this? |
|
Looks like pylint-dev/pylint#3524 covers this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
The new release of pylint (2.5) needs to have the package installed,
whether intentional or not, this has been failing our FPGA repos.
How long should this take to review?
Types of changes:
Checklist: