Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setuptools/importlib-metadata version issue #163

Merged
merged 2 commits into from May 9, 2022
Merged

Conversation

drasmuss
Copy link
Member

@drasmuss drasmuss commented May 2, 2022

Motivation and context:

More recent setuptools versions require more recent importlib-metadata versions, which doesn't get installed automatically by setuptools. See pypa/setuptools#3293.

Interactions with other PRs:

Depends on nengo/nengo-sphinx-theme#73 (not directly for this functionality, just in order to get the doc build passing)

How has this been tested?

Covered by existing tests.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbekolay tbekolay merged commit 9076cb8 into master May 9, 2022
@tbekolay tbekolay deleted the fix-setuptools branch May 9, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants