Reload tf_indices outside while in get_tensor #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasmuss
force-pushed
the
signal_fix
branch
2 times, most recently
from
6cff5af
to
bcf714d
Compare
Add log message indicating which device NengoDL is running on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorSignal indices are loaded on-demand during the build process (since we may never need them, depending on how signals are merged). This means that, depending on when a Signal is first accessed, the indices may be initialized inside or outside the Simulation while loop. Normally that doesn't matter, unless we want to access that Signal through
tensor_graph.get_signal. That accesses the signal value statically, outside of the while loop, so the indices also need to be created outside the while loop. This makes sure that is the case.Fixes #56