Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more detail to remote termination #61

Merged
merged 1 commit into from Apr 29, 2020
Merged

Add more detail to remote termination #61

merged 1 commit into from Apr 29, 2020

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Apr 24, 2020 •
edited

Motivation and context:

There was no information given when the device side shutdown the simulation. Now there is

Interactions with other PRs:

  • nengo/nengo-pynq#15
  • nengo/nengo-de1#8
  • (indirectly) Testing #55 tests will need to be updated to reflect the change

How has this been tested?

Manually tested various conditions

How long should this take to review?

  • Average (neither quick nor lengthy)

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • N/A I have run the test suite locally and all tests passed.

@bmorcos bmorcos mentioned this pull request Apr 24, 2020
Merged
8 tasks
@bmorcos bmorcos force-pushed the error-str branch 2 times, most recently from 0b43edc to 0f7ddbf Compare April 28, 2020 18:59
@bmorcos
Add more detail to remote termination
4dce435 
- Add error codes to denote remote exit conditions
@bmorcos bmorcos merged commit 4dce435 into master Apr 29, 2020
@bmorcos bmorcos deleted the error-str branch April 29, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchoo xchoo xchoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmorcos @xchoo