Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.0 #148

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Release v1.3.0 #148

merged 3 commits into from
Oct 6, 2017

Conversation

tbekolay
Copy link
Member

@tbekolay tbekolay commented Oct 6, 2017

This is the release commit for v1.3.0, and a commit to fix / xfail some recent Nengo changes:

  • Raise an error if sim is run for < dt seconds nengo#1357 changed what happens in sim.run; those changes were ported back here no problem
  • Fixes bug where multiple identical indexed slices are ignored nengo#1361 fixed a bug with repeated indices in lists used to slice Nengo objects; those tests fail here so I xfailed them for now
  • Piecewise param nengo#1355 introduced a Piecewise process with interpolation. The interpolation tests fail because we're evaluating the function at t=0.1, which in Nengo OpenCL's float32 in slightly more than 0.1, resulting in the interpolation function returning 0, which is the fill value. There are some things we could do the fix this (namely having the interp1d extrapolate instead of filling with 0) but that'll take some discussion, so xfailing it for now so we can get the release done

And error if running negative timesteps. Matches the behavior of
the reference simulator, which is part of the test suite.

Also xfails two newly added tests, one for advanced indexing,
and one for the Piecewise process.
@tbekolay tbekolay requested a review from hunse October 6, 2017 18:56
Copy link
Collaborator

@hunse hunse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I added a commit to raise an error if using duplicate indices. This should be moved before the release commit.

@tbekolay
Copy link
Member Author

tbekolay commented Oct 6, 2017

Great, will do. Thanks!

@tbekolay tbekolay merged commit 06846a0 into master Oct 6, 2017
@tbekolay tbekolay deleted the release-130 branch October 6, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants