Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release commit for v1.3.0, and a commit to fix / xfail some recent Nengo changes:
sim.run
; those changes were ported back here no problemt=0.1
, which in Nengo OpenCL's float32 in slightly more than0.1
, resulting in the interpolation function returning0
, which is the fill value. There are some things we could do the fix this (namely having theinterp1d
extrapolate instead of filling with 0) but that'll take some discussion, so xfailing it for now so we can get the release done