Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor features/fixes in examples #182

Merged
merged 1 commit into from Oct 6, 2020
Merged

Minor features/fixes in examples #182

merged 1 commit into from Oct 6, 2020

Conversation

atait
Copy link
Contributor

@atait atait commented Sep 21, 2020

  • YAML records, so they can be copy-pasted into one file for plotting
  • control of on-device probe memory, both for Nengo OCL and Nengo DL
  • The ocl_profile command line option no longer causing "simulator closed" error

No changes to nengo_ocl package

hunse
hunse approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@hunse hunse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atait I've made a few fixups. Let me know if they look good and I'll merge. I'm also planning on squashing everything before I merge; these are fairly related changes so I think they can be one commit.

@atait
Copy link
Contributor Author

atait commented Oct 6, 2020

All of these changes look great. I like how you can compare across benchmarks now. Thanks for fixing it up. Squash for sure – the numerous commits hopefully helped with review.

@atait @hunse
Fixes to benchmarks
0e6ba1c 
- Save benchmark records as yaml for human viewing and concatenating
- Fix bug where profiling must be accessed before simulator is closed
- Free memory between benchmark simulations
- Support plotting for Watts-Strogatz benchmark (and future
  benchmarks that have neurons instead of dims).
- Nengo OCL:
- Nengo DL: looping simulation
- Properly support multiple benchmarks on the same plot
- Add ``n_prealloc_probes`` to ``benchmark_wattsstrogatz.py`` to
  benchmark on-device probe memory sizes.
- benchmark_wattsstrogatz.py now returns "neurons" instead of
  "n_neurons" to match benchmark_circconv.py

Co-authored-by: Eric Hunsberger <eric.hunsberger@appliedbrainresearch.com>
@hunse hunse merged commit 0e6ba1c into nengo:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunse hunse hunse approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atait @hunse