Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DateTimeOffset #41

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Support DateTimeOffset #41

merged 4 commits into from
Sep 17, 2022

Conversation

nenoNaninu
Copy link
Owner

Related #29

@nenoNaninu
Copy link
Owner Author

MessagePack can only have UTC in the timestamp. There is no specification for storing as local time. On the other hand, MessagePack for C# serializes DateTimeOffset, which is stored as local time.

example

2022-09-17T18:27:56.520+09:00 means local time + offset.

The MessagePack specification only accepts UTC for timestamp. Therefore, we expect it to be saved in the following format.

expect : ["2022-09-17T09:27:56.52Z", 540]
actual : ["2022-09-17T18:27:56.52Z", 540]

@nenoNaninu nenoNaninu merged commit fee62c3 into main Sep 17, 2022
@nenoNaninu nenoNaninu deleted the support_DateTimeOffset branch September 17, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nenoNaninu