Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing header in dev branch of 3rdparty/tvm #77

Merged
merged 3 commits into from Jul 25, 2019
Merged

Fix missing header in dev branch of 3rdparty/tvm #77

merged 3 commits into from Jul 25, 2019

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jul 25, 2019

When I was building the GPU Image Classification container, I got error

error: strlen was not declared in this scope

because the header <cstring> was missing from the file src/runtime/cuda/cuda_device_api.cc. (This error only happens when CUDA is enabled.)

We should fix 3rdparty/tvm, but for now I use sed to add the line #include <cstring> to src/runtime/cuda/cuda_device_api.cc on the fly. Update. The fix is now submitted to upstream: apache/tvm#3621.

Also, this pull request adds GPU image classification container to the Jenkins CI pipeline.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hcho3 hcho3 requested a review from zhiics July 25, 2019 03:56
Copy link
Contributor

@ziyu-guo ziyu-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcho3 hcho3 merged commit 7d56499 into neo-ai:master Jul 25, 2019
@hcho3 hcho3 deleted the fix_missing_header branch July 25, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants