Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contract IDs to Contract Model #1975

Closed
spencercorwin opened this issue Feb 10, 2020 · 1 comment
Closed

Add Contract IDs to Contract Model #1975

spencercorwin opened this issue Feb 10, 2020 · 1 comment
Assignees
@spencercorwin
Labels
area/client Categorize issue or PR as client (@neo-one/client) related

Comments

@spencercorwin
Copy link
Collaborator

Description

NEO has added a contract ID property to Contract Model. See the discussion and PR here: neo-project/neo#1400

Make sure to implement the Contract ID usage where appropriate, like in various SysCalls and OpCodes and StorageItems. See their PR for guidance.
@spencercorwin spencercorwin self-assigned this Feb 10, 2020
@spencercorwin spencercorwin added the area/client Categorize issue or PR as client (@neo-one/client) related label Feb 27, 2020
@spencercorwin
Copy link
Collaborator Author

Needs to be done in Client as well for 3.0

@spencercorwin spencercorwin changed the title [NEO 3.0] Add Contract IDs to Contract Model [Neo 3.0] Add Contract IDs to Contract Model Apr 23, 2020
@spencercorwin spencercorwin changed the title [Neo 3.0] Add Contract IDs to Contract Model Add Contract IDs to Contract Model May 22, 2020
@spencercorwin spencercorwin mentioned this issue Aug 20, 2020
Merged
@spencercorwin spencercorwin mentioned this issue Aug 27, 2020
Merged
@spencercorwin spencercorwin mentioned this issue Aug 30, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencercorwin spencercorwin

Labels
area/client Categorize issue or PR as client (@neo-one/client) related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spencercorwin