Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo submodule issue #915

Closed
shargon opened this issue Feb 19, 2024 · 6 comments
Closed

Neo submodule issue #915

shargon opened this issue Feb 19, 2024 · 6 comments
Assignees

Comments

@shargon
Copy link
Member

shargon commented Feb 19, 2024

When we create the testing package, the neo reference used is the submodule version, instead of the neo package.

image

@shargon
Copy link
Member Author

shargon commented Feb 19, 2024

@Jim8y ?

<Project Sdk="Microsoft.NET.Sdk">

	<PropertyGroup>
		<Title>Neo.SmartContract.Testing</Title>
		<TargetFrameworks>netstandard2.1;net7.0</TargetFrameworks>
		<LangVersion>latest</LangVersion>
		<PackageId>Neo.SmartContract.Testing</PackageId>
		<PackageTags>NEO;Blockchain;Smart Contract</PackageTags>
		<Description>TestEngine for NEO smart contract testing.</Description>
		<IncludeContentInPack>true</IncludeContentInPack>
		<ContentTargetFolders>content</ContentTargetFolders>
		<Nullable>enable</Nullable>
		<NoWarn>$(NoWarn);NU5128</NoWarn>
	</PropertyGroup>

	<ItemGroup>
		<PackageReference Include="Neo" Version="3.6.2-CI00001" />
		<PackageReference Include="Moq" Version="4.20.70" />
		<PackageReference Include="MSTest.TestFramework" Version="3.1.1" />
	</ItemGroup>

	<!--<ItemGroup>
	  <ProjectReference Include="..\..\neo\src\Neo\Neo.csproj" />
	</ItemGroup>-->

</Project>

@Jim8y
Copy link
Contributor

Jim8y commented Feb 19, 2024

is 3.6.2-CI00001published? i dont know what it means can not resolve it, because master neo has to be published?

@shargon
Copy link
Member Author

shargon commented Feb 19, 2024

Sent

@vncoelho
Copy link
Member

That PR about devcontainer has a solution definition as well

@shargon
Copy link
Member Author

shargon commented Feb 19, 2024

is 3.6.2-CI00001published? i dont know what it means can not resolve it, because master neo has to be published?

Is published, is my proposed solution, remove the reference to the submodule, and link with the package, if someone want to debug it, just uncomment

@shargon
Copy link
Member Author

shargon commented Feb 21, 2024

Fixed

@shargon shargon closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants