Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event name in NotifyEventArgs #265

Closed
Tommo-L opened this issue Jun 22, 2020 · 3 comments · Fixed by #267
Closed

Add event name in NotifyEventArgs #265

Tommo-L opened this issue Jun 22, 2020 · 3 comments · Fixed by #267
Assignees
@joeqian10
Labels
discussion

Comments

@Tommo-L
Copy link
Contributor

Tommo-L commented Jun 22, 2020

Apply neo-project/neo#1701

  • Update Nep5Tracker plugin
    • Add eventName field in NotifyEventArgs
@Tommo-L Tommo-L mentioned this issue Jun 22, 2020
Closed
@joeqian10
Copy link
Contributor

Shall we also modify other places where NotifyEventArgs are used? For example, in LogReader.cs:
image

@joeqian10
Copy link
Contributor

@erikzhang @shargon @Tommo-L I can fix and close this issue first, and modify those places in later PRs. How do you like it?

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Jun 23, 2020

One pr is enough.

@joeqian10 joeqian10 mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeqian10 joeqian10

Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add EventName to NotifyEventArgs joeqian10/neo-modules
2 participants
@joeqian10 @Tommo-L