This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
typo, comment #847
Merged
typo, comment #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2056047779
💛 - Coveralls |
shargon
suggested changes
Jan 20, 2022
erikzhang
reviewed
Jan 25, 2022
erikzhang
reviewed
Jan 26, 2022
shargon
reviewed
Jan 27, 2022
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Shargon <shargon@gmail.com>
Jim8y
commented
Jan 27, 2022
shargon
previously approved these changes
Jan 27, 2022
erikzhang
reviewed
Jan 30, 2022
neo-cli/CLI/Logger.cs
Outdated
Comment on lines
81
to
82
| default: | ||
| throw new ArgumentOutOfRangeException(nameof(level), level, null); |
erikzhang
reviewed
Mar 27, 2022
neo-cli/CLI/MainService.Node.cs
Outdated
| @@ -71,7 +71,7 @@ private void OnShowStateCommand() | |||
| NeoSystem.LocalNode.Tell(Message.Create(MessageCommand.Ping, PingPayload.Create(NativeContract.Ledger.CurrentIndex(NeoSystem.StoreView)))); | |||
| await Task.Delay(NeoSystem.Settings.TimePerBlock, cancel.Token); | |||
| } | |||
| }); | |||
| }, cancel.Token); | |||
There was a problem hiding this comment.
It's not necessary. Because it is already judged in the loop.
erikzhang
approved these changes
Mar 29, 2022
shargon
approved these changes
Mar 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.