Transaction failed when multi addresses in one wallet.

[superboyiii]

It's a bit odd, but it's true. When multi addresses are generated in a wallet, no need too many, two or three addresses is enough, and then send a bit gas to each one. Then if you make a transaction and if the from address has more than double of your transfer value, the tx will be made successfully. Else, it will return Failed execution. My example is like this:

For example, when value is 150 or 140, it will choose the 5th or the 7th address. They have balance of 150, and 150 and 140 is more than 150/2, then execution failed.

[shargon]

So it fail when it need to split the amount, right?

[superboyiii]

Not for all, but seems for NEO transaction, 1/2 of the from address balance is a watershed. And I also find when making a GAS transaction, it'll look for the least balance(except from address) to pay for net_fee + sys_fee. If this address doesn't have enough fee, then execution fails, no matter other addresses in this wallet have enough balance or not.

[shargon]

I send 10 to one, 5 to other, and send back 15 to the original, and all works as expected, could you provide me a small sample ?

[nicolegys]

@shargon here is a small sample

[shargon]

With gas could be different, because maybe it need more gas for the fee. Could you provide me a small example with neo? i think that is easier to test with neo

[superboyiii]

With gas could be different, because maybe it need more gas for the fee. Could you provide me a small example with neo? i think that is easier to test with neo

@shargon Got it? When the transfer value is more than fromAddress.balance/2, it always look for the least balance address to pay for Fee. If the gas balance in that address is not enough to pay for fee, transaction execution will fail. But if the transfer value is less than fromAddress.balance/2, transaction can be made successfully.

[shargon]

Step 1

Step 2

Error:

There is not enough gas in the wallet one for send this to wallet two

Then , in the second step of the loop

It fail because you don't have enough balance in the snapshot

[nicolegys]

We change snapshot to snapshot.Clone(), then this issue is fixed.

[shargon]

This code

neo/neo/Wallets/Wallet.cs

Lines 306 to 320 in 68271a9

	using (ApplicationEngine engine = ApplicationEngine.Run(script, snapshot, tx, testMode: true))
	{
	if (engine.State.HasFlag(VMState.FAULT))
	throw new InvalidOperationException($"Failed execution for '{script.ToHexString()}'");
	tx.SystemFee = Math.Max(engine.GasConsumed - ApplicationEngine.GasFree, 0);
	if (tx.SystemFee > 0)
	{
	long d = (long)NativeContract.GAS.Factor;
	long remainder = tx.SystemFee % d;
	if (remainder > 0)
	tx.SystemFee += d - remainder;
	else if (remainder < 0)
	tx.SystemFee -= remainder;
	}
	}

Should be executed outside the loop, and the loop, shoud be only for find the gas account

[shargon]

Yes, it works. Do you want to apply the patch, or i do?

[shargon]

Nice catch team 😉 ! @superboyiii @nicolegys

[nicolegys]

You apply the patch 😉

[superboyiii]

@shargon Thanks for your investigation.