Improve the stability of block time

[i359]

What causes the unstable block time, the network delay of part nodes or other ？

[igormcoelho]

Which instability... you mean 20, 21, 23 secs ?

This have improved a lot already hahaha looks stable to me 😂

But really, there's a solution for this, in my opinion, but this requires changing CurrentBlockTime to PrevBlockTime (I opened an issue for it). Without that, its nearly impossible to get zero delay here.

Regarding tx count differences, I guess it may have been solved already on base dev code, looks like some existing p2p and TaskManager issues.

[lock9]

🤔
@igormcoelho But this would be just a visual change right? Or do you think the displayed time is incorrect?

[igormcoelho]

Nope, I mean, to actually finish blocks in time (or nearly close to time).

[i359]

Maybe further improvements are needed, thanks！

[igormcoelho]

I think these 39 and 42 seconds may involve changeviews... only looking at node logs (or p2p logs) to be sure.

[lock9]

Hi @i359, as I mentioned in the other issue, I didn't find evidence that this problem is really happening. Not sure if it was caused by some network problem but in any case, if you think this is really happening, feel free to create a new issue or request someone from the team to reopen it.
Thanks

[vncoelho]

@i359, several minor commits were made from v2.10.2 to 2.10.3, check it out. I believe nodes stability may improve.

Thanks for reporting and discussing. The topic may still need further adjustment which we are investigating closely.