Create only one cloned snapshot for persist?

[Qiao-Jin]

Currently during persisting, for each transaction we will create a cloned snapshot, which can be time consuming for heavy workload:

neo/src/neo/Ledger/Blockchain.cs

Line 501 in a5cf5b2

using (ApplicationEngine engine = new ApplicationEngine(TriggerType.Application, tx, snapshot.Clone(), tx.SystemFee))

So why not create a snapshot beforehead and reuse it for all transactions? Such functionality would enhance TPS by about 50% in my local env.

[shargon]

If you don't clone the snapshot, and the transaction FAULT, the state will be persisted.

[Qiao-Jin]

If you don't clone the snapshot, and the transaction FAULT, the state will be persisted.

That's right, so we need to clone once more for such occasions:)