Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateStandardMultisigAccount interop #2342

Closed
roman-khimov opened this issue Feb 16, 2021 · 1 comment · Fixed by #2343
Closed

CreateStandardMultisigAccount interop #2342

roman-khimov opened this issue Feb 16, 2021 · 1 comment · Fixed by #2343
Assignees
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
There is a System.Contract.CreateStandardAccount interop that converts given key into standard script hash, but we can't do the same for multisig accounts which can also be useful. Multisig scripts are much more complex than single-signature scripts, so implementing CreateMultiSigRedeemScript in smart contract is time-consuming and error-prone.

The need to calculate proper multisig script hash is relevant for NeoFS governance scheme implementation (#2267) combined with P2P Notary system (#1573), we have all inner ring node keys in the contract, but we need to check for multisig witness of these keys.

The same problem can occur with role management contract which has GetDesignatedByRole method returning key array, so the user of this method can get this array but can't easily derive multisig script hash from it.

Do you have any solution you want to propose?
Provide System.Contract.CreateStandardMultisigAccount interop that will have the same input parameters as CreateMultiSigRedeemScript method (number of valid signatures required and a list of keys) and will return script hash to the caller.

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • SDK
@roman-khimov roman-khimov added the discussion Initial issue state - proposed but not yet accepted label Feb 16, 2021
@shargon shargon self-assigned this Feb 16, 2021
@vncoelho
Copy link
Member

Since there is a need for this Native embedded feature I think it is worth implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants