added dbms upgrade resolver and tests #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk05
commented
Sep 3, 2021
Comment on lines
+46
to
+51
| const {name, id} = await dbmss.environment.dbmss.install( | ||
| dbmss.createName(), | ||
| TestDbmss.NEO4J_VERSION, | ||
| TestDbmss.NEO4J_EDITION, | ||
| TestDbmss.DBMS_CREDENTIALS, | ||
| ); |
There was a problem hiding this comment.
had to do it this way as I am not sure why using createDbms was causing issues for me. Will investigate at the end if I have time.
There was a problem hiding this comment.
this is how dbmss were installed in upgrade.test in the common package too
jk05
force-pushed
the
web-api-update_dbms-upgrade
branch
from
d70bb15
to
cfe1c86
Compare
jk05
force-pushed
the
web-api-update_dbms-upgrade
branch
2 times, most recently
from
ca3c8fb
to
13bf68d
Compare
jk05
force-pushed
the
web-api-update_dbms-upgrade
branch
3 times, most recently
from
e4845b4
to
8bc6f4b
Compare
nglgzz
previously approved these changes
Sep 17, 2021
jk05
force-pushed
the
web-api-update_dbms-upgrade
branch
from
8bc6f4b
to
dc23531
Compare
nglgzz
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Added resolver and test for
dbms.upgradeWhat is the current behavior?
No resolver for
dbms.upgradeWhat is the new behavior?
Can now upgrade dbmss via the web package
Does this PR introduce a breaking change?
no
Other information:
Have had to mould the test dbms install slightly to get it to work as I am not sure what is causing an issue for me at the moment. Will look at the end if I have time.