Implement Into/TryFrom BoltType for Vec and Into for f64 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very important feature. |
kkharji
referenced
this pull request
in kkharji/neo4jrs
Mar 30, 2022
Co-authored-By: Peikos <Peikos@github.com> https://github.com/yehohanan7/neo4rs/pull/11
|
Hey, any idea when this'll be merged? |
Nuckal777
referenced
this pull request
in Nuckal777/neo4rs
Apr 29, 2022
|
Can we merge this please? |
reduxdj
approved these changes
Oct 28, 2022
|
@yehohanan7 @Peikos @Alfiec7113 I'm not sure who is able to merge but this is such a huge enabler of a PR! Now that we're approved think we could push the shiny merge button? Thank you heaps for this work. It is excellent! |
|
Hey all, sorry for the delay. We moved this repository into the Neo4j Labs organization and we'll be taking over maintenance and development. @Peikos I made some small tweaks to your implementation, we can merge it, thanks for the initial contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state, neo4rs does not appear to support lists/vectors in node properties and probably elsewhere due to missing
IntoandTryFromimplementations. This patch firstly adds support forVec<A>givenAis already convertible to/fromBoltType. Secondly, an implementation ofInto<BoltType> for f64is provided, as this seems to be already supported the other way around.These changes together should allow using neo4rs to work with databases containing vector embeddings. Edits by maintainers are on, so feel free to edit anything if it's not up to standard.