Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking! Move a lot of get::<T> functions to use serde instead of TryFrom<BoltType> #120

Merged
merged 42 commits into from
Oct 20, 2023
Merged

Breaking! Move a lot of get::<T> functions to use serde instead of TryFrom<BoltType> #120

merged 42 commits into from
Oct 20, 2023

Conversation

knutwalker
Copy link
Collaborator

  • Most usages should keep working as is
  • Getting the timezone offset requires using neo4rs::Offset instead of chrono::FixedOffset as the latter one does not implement serde::Deserialize
  • A lot of other things are now possible

@knutwalker knutwalker force-pushed the serde-get branch 2 times, most recently from b43c139 to 39d7e92 Compare October 14, 2023 20:51
knutwalker and others added 28 commits October 14, 2023 23:37
@knutwalker
Flesh out all the DeError kinds, mostly copied from serde
9b8293a
@knutwalker
Split serde mod into muliple modules
6275c3f
@knutwalker
Add Deserialize impls for BoltType and related (WIP)
be59f77
@knutwalker
Move kind into mod
d1bc5a0
@knutwalker
Move additional element data into its own mod
d1d14b7
@knutwalker
Move element builders into their own mod
83ac28a
@knutwalker
Implement AdditionalDeserializer with delegate
7a813fa
@knutwalker
Move node related deserialize(r) into its own module
48f957b
@knutwalker
Move relation related deserialize(r) into its own module
6f16153
@knutwalker
Move unbounded relation related deserialize(r) into its own module
722aef2
@knutwalker
Merge remaining mods into its own BoltType related module
7566d1a
@knutwalker
Remove read API now that we can use get for this
ec70637
@knutwalker
Move impl blocks to theirs respective modules
0ca7ff1
@knutwalker
Remove dependency on serde_derive from the main scope
6a653ed 
We still have it in our tests, but the regular dependency tree does no longer include serde_derive.
The dev-dependency is restricted to a slightly older version due versions >=1.0.172,<1.0.184 shipping and executing binary code on the host at build time.
@knutwalker
Support DateTime into chrono::DateTime<FixedOffset> via serde
58e5b68
@knutwalker
Fix compile error for unbounded relationships example
8f8b2b7
@knutwalker
Change newtype_deser macro to allow any type expr as the inner type
68f9f9d
@knutwalker
Implement all element data methods in terms of the key/value enums
bbb981f
@knutwalker
Don't derive Default for the element extractors
c7a656f
@knutwalker
Move chrono imports to test scope
be3f479
@knutwalker
Add std chrono feature, as we actually require it
aa97cef
@knutwalker
Use a newer serde version in tests that no longer include the blob
d0f4797
@knutwalker
Add extractors for Nodes/Rels/Ids
19bbf25
@knutwalker
breaking! Rename the Path fields ids to indices
7ee8a3e
@knutwalker
Add support for paths in serde
7eaf4ef
@knutwalker
Expose Path serde support in the public type
d0a7430
@knutwalker
Allow string based enum conversion as well for the cenums
f762759
@knutwalker
Elide lifetimes
5a4aed0
@knutwalker knutwalker marked this pull request as ready for review October 14, 2023 21:40
@knutwalker knutwalker merged commit 632ae44 into neo4j-labs:master Oct 20, 2023
25 checks passed
@knutwalker knutwalker deleted the serde-get branch October 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@knutwalker