Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more From impls for numbers #58

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Add more From impls for numbers #58

merged 3 commits into from
Feb 24, 2023

Conversation

knutwalker
Copy link
Collaborator

  • Implement From for most number types for BoltType
  • Implement From byte slice for BoltType
  • Update doc test for raw bytes to use a byte slice

knutwalker and others added 3 commits February 24, 2023 17:31
@knutwalker @s1ck
Implement From for most number types for BoltType
1f75673 
Co-Authored-By: Martin Junghanns <nerdfaktor42@mailbox.org>
@knutwalker @s1ck
Implement From byte slice for BoltType
5be540c 
Co-Authored-By: Martin Junghanns <nerdfaktor42@mailbox.org>
@knutwalker @s1ck
Update doc test for raw bytes to use a byte slice
039c48a 
Co-Authored-By: Martin Junghanns <nerdfaktor42@mailbox.org>
@knutwalker knutwalker requested a review from s1ck February 24, 2023 16:40
s1ck
s1ck approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@s1ck s1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@s1ck s1ck merged commit b3b3123 into neo4j-labs:master Feb 24, 2023
@knutwalker knutwalker deleted the update-from-impls branch February 27, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1ck s1ck s1ck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knutwalker @s1ck