Skip to content

Commit

Permalink
Merge branch 'develop' into feature/VULCAN-126-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
nielsdejong committed Nov 10, 2023
2 parents b758843 + 295857b commit be133db
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
7 changes: 6 additions & 1 deletion src/application/Application.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
applicationGetStandaloneSettings,
applicationGetSsoSettings,
applicationHasReportHelpModalOpen,
applicationIsStandalone,
} from '../application/ApplicationSelectors';
import {
createConnectionThunk,
Expand Down Expand Up @@ -70,6 +71,7 @@ const Application = ({
connectionModalOpen,
reportHelpModalOpen,
ssoSettings,
standalone,
standaloneSettings,
aboutModalOpen,
loadDashboard,
Expand Down Expand Up @@ -140,7 +142,8 @@ const Application = ({
</Suspense>
<NeoConnectionModal
open={connectionModalOpen}
dismissable={connected}
connected={connected}
dismissable={!standalone}
connection={connection}
ssoSettings={ssoSettings}
standalone={standaloneSettings.standalone}
Expand All @@ -149,6 +152,7 @@ const Application = ({
onSSOAttempt={onSSOAttempt}
setConnectionProperties={setConnectionDetails}
onConnectionModalClose={onConnectionModalClose}
setWelcomeScreenOpen={setWelcomeScreenOpen}
></NeoConnectionModal>
<NeoWelcomeScreenModal
welcomeScreenOpen={welcomeScreenOpen}
Expand Down Expand Up @@ -191,6 +195,7 @@ const mapStateToProps = (state) => ({
shareDetails: applicationGetShareDetails(state),
oldDashboard: applicationGetOldDashboard(state),
ssoSettings: applicationGetSsoSettings(state),
standalone: applicationIsStandalone(state),
standaloneSettings: applicationGetStandaloneSettings(state),
connectionModalOpen: applicationHasConnectionModalOpen(state),
aboutModalOpen: applicationHasAboutModalOpen(state),
Expand Down
15 changes: 10 additions & 5 deletions src/modal/ConnectionModal.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
import React, { useEffect } from 'react';
import { SSOLoginButton } from '../component/sso/SSOLoginButton';
import { Button, Dialog, Switch, TextInput, Dropdown, TextLink } from '@neo4j-ndl/react';
import { PlayIconOutline } from '@neo4j-ndl/react/icons';
import { Button, Dialog, Switch, TextInput, Dropdown, TextLink, IconButton } from '@neo4j-ndl/react';
import { PlayIconOutline, ArrowLeftIconOutline } from '@neo4j-ndl/react/icons';
/**
* Configures setting the current Neo4j database connection for the dashboard.
*/
export default function NeoConnectionModal({
connected,
open,
standalone,
standaloneSettings,
ssoSettings,
connection,
dismissable = false,
dismissable,
createConnection,
setConnectionProperties,
onConnectionModalClose,
onSSOAttempt,
setWelcomeScreenOpen,
}) {
const protocols = ['neo4j', 'neo4j+s', 'neo4j+ssc', 'bolt', 'bolt+s', 'bolt+ssc'];
const [ssoVisible, setSsoVisible] = React.useState(ssoSettings.ssoEnabled);
Expand Down Expand Up @@ -48,10 +50,13 @@ export default function NeoConnectionModal({
size='small'
open={open}
onClose={() => {
dismissable ? onConnectionModalClose() : null;
onConnectionModalClose();
if (!connected) {
setWelcomeScreenOpen(true);
}
}}
aria-labelledby='form-dialog-title'
disableCloseButton
disableCloseButton={!dismissable}
>
<Dialog.Header id='form-dialog-title'>{standalone ? 'Connect to Dashboard' : 'Connect to Neo4j'}</Dialog.Header>
<Dialog.Content className='n-flex n-flex-col n-gap-token-4'>
Expand Down

0 comments on commit be133db

Please sign in to comment.