Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Selector Display option #274

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Conversation

BennuFire
Copy link
Collaborator

This adds an option to display a different property than the one is going to be assign to the params.

This will close #241

@BennuFire BennuFire linked an issue Nov 29, 2022 that may be closed by this pull request
cypress/integration/start_page.spec.js Outdated Show resolved Hide resolved
const limit = settings.suggestionLimit ? settings.suggestionLimit : 5;
const deduplicate = settings.deduplicateSuggestions !== undefined ? settings.deduplicateSuggestions : true;
const searchType = settings.searchType ? settings.searchType : "CONTAINS";
const caseSensitive = settings.caseSensitive !== undefined ? settings.caseSensitive : false;
if (settings['type'] == "Node Property") {
const newQuery = "MATCH (n:`" + entityType + "`) \n"+
"WHERE "+(caseSensitive ? "" : "toLower")+"(toString(n.`" + propertyType + "`)) "+searchType+
"WHERE "+(caseSensitive ? "" : "toLower")+"(toString(n.`" + propertyDisplay + "`)) "+searchType+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move the ternary caseSensitive ? "" : "toLower" out of the string and to place it in a const on line 118.5 in order to be able to reuse it on line 129

We can also directly replace the line 118 by something like: const toLowerOrEmptyString = (settings.caseSensitive || false) ? "" : "toLower"; or maybe in two lines for more readability, one with the caseSensitive const definition and the second to define the "toLower" const

What do you think of the template string style with ${} ? Can maybe be more readable than the "" + "" synthax but not sure here

" "+(caseSensitive ? "" : "toLower")+"($input) \n"+
"RETURN " + (deduplicate ? "DISTINCT" : "") + " n.`" + propertyType + "` as value "+
"RETURN " + (deduplicate ? "DISTINCT" : "") + " n.`" + propertyType + "` as value, "+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem for this DISTINCT and the fact of reusing it on line 131

} else {
queryCallback("CALL db.propertyKeys() YIELD propertyKey as propertyName WITH propertyName WHERE toLower(propertyName) CONTAINS toLower($input) RETURN DISTINCT propertyName LIMIT 5", { input: value }, setPropertyRecords);
}
}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this code can be moved in a dedicated function in order to have a more readable component, what do you think ?

src/chart/parameter/ParameterSelectionChart.tsx Outdated Show resolved Hide resolved
src/chart/parameter/ParameterSelectionChart.tsx Outdated Show resolved Hide resolved
src/chart/parameter/ParameterSelectionChart.tsx Outdated Show resolved Hide resolved
}
}}
renderInput={(params) => <TextField {...params} InputLabelProps={{ shrink: true }}
placeholder="Start typing..."
label={helperText ? helperText : label + " " + property} variant="outlined" />}
label={helperText ? helperText : label + " " + propertyDisplay} variant="outlined" />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

@nielsdejong
Copy link
Collaborator

@BennuFire @bastienhubert
During my merge with the new prettified/linted develop branch, the comments made by Bastien became tagged as "outdated", but they are still relevant.

I'm not too confident to merge this into release 2.2.1 as:

  1. it's a breaking change for old dashboards
  2. I haven't had the time to test this properly.

I'd suggest to leave this for 2.2.2 so that we can implement Bastien's suggestions and test further. I also don't want to introduce breaking changes unless we are doing a 2.3 release.

@nielsdejong
Copy link
Collaborator

I've rebased this with the latest develop - here's some final requests from my side before merging:

  • I think "property display" should be disabled by default, as new users will likely be confused about what it means. Could you make an advanced parameter "Enable property display text override" (on/off)? 
  • when a user selects a property by their display text, the value in the box jumps to the actual value. Could we make fix this? it makes for a bit of a strange user experience. (see image).
  • Can we make this backwards compatible with versions <=2.2.1 by taking the first value of the result array here (https://github.com/neo4j-labs/neodash/pull/274/files#diff-9d5b322b523c8c62b724b80f31f6f87cf02a7b936678934553267cd7bf8098b1R109-R120) if the second does not exist?
  • Could you rename 'Property display' to 'override property display value'? That will give users a clearer understanding of the feature.
    image

Copy link
Collaborator

@nielsdejong nielsdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@nielsdejong nielsdejong merged commit 57bc02a into develop Feb 2, 2023
nielsdejong added a commit that referenced this pull request Feb 2, 2023
* Master to dev Release (#259)

* TableChart : Auto-hide columns prefixed with __

* Master to dev Release (#259)

* Added prettier (config based on neo4j/nx repository)

* Added eslint and husky (config based on neo4j/nx repository)

* Updated eslint config to be as light as possible with Typescript

* Updated all files with prettier and linter, refactored files to avoid errors

* Added Eslint check step in Github workflows

* Updated all files with prettier and linter after rebase on Develop branch

* Squash Security Bumbs (#281)

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump loader-utils from 1.4.0 to 1.4.2

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update yarn.lock

* yarn gallery util 3.2.1

* bump

* remove lodash 4.17.15 lock

* remove minimatch 3.0.4 lock

* remove d3 color lock

* remove node.fet color lock

* ut

* no node fetch

* lod

* lod2

* ncheck

* d3 init

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#264)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes #160 (#269)

* Fix : Replace parameter in iFrame URLs (#276)

* Fix : Replace parameter in iFrame URLs

* Fix wrong merge conflict

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#290)

* Bump loader-utils from 1.4.0 to 1.4.2 (#265)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Crash on Boolean options parameter selection (#285)

* bug on non string values

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Hotfix for Neo4j container issues with 5.3 (#293)

* Updated deployment scripts to use minimal build without source maps (#271)

* Changed build script to use mimimal (no source map) deployment

* Added TODOs based on comments

* Changing card image download logic  (#273)

* feature(): Changing download logic for card download by downloading the entire card instead of just the view. This kind of change adds also the buttons to the downloaded image, that is not ideal.

* fix(download report image): added missing ref for card expanded view

* Removed package-lock.json

Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Dynamic Card titles (#270)

* change of names

* Resolving conflicts

* Bug fix

* Refactoring

* Fixed replacement of params in card headers

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Docs on custom map provider (#282)

* Docs on custom map provider

* Update docs/modules/ROOT/pages/user-guide/reports/map.adoc

Co-authored-by: MariusC <marius.conjeaud@outlook.com>

Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added release notes, bumped version number

* Fixed style issues introduced by 2.2.1 + some of the console warnings in development mode

* Some more minor style fixes in modal text

* Fixed unclear phrasing in extensions modal

* Added wine dashboard to gallery (#298)

* Added wine dashboard

* Updated wine dashboard in gallery

* Added jokes dashboard (#300)

* Added citation graph (#306)

* Bump json5 from 1.0.1 to 1.0.2 (#302)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump json5 from 2.2.1 to 2.2.3 in /docs (#303)

Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump json5 from 1.0.1 to 1.0.2 in /gallery (#304)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added assessment gallery

* Bump convict from 6.2.3 to 6.2.4 in /docs (#307)

Bumps [convict](https://github.com/mozilla/node-convict) from 6.2.3 to 6.2.4.
- [Release notes](https://github.com/mozilla/node-convict/releases)
- [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mozilla/node-convict/commits)

---
updated-dependencies:
- dependency-name: convict
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* use link (#295)

add  a link to the neodash repo

* upgrade to @neo4j-cypher/react-codemirror package (#286)

* upgrade to neo4j-cypher/react-codemirror package

* bump @neo4j-cypher/react-codemirror

* remove unused old cypher editor component

* fix integration tests (missing className)

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror to latest

add codemirror markdown packages as an experiment

* enable switching between cypher/markdown languages

* update yarn.lock

* fix lint errors

* update @neo4j-cypher/react-codemirror to latest (fix line number text height)

* Fixed breaking integration tests

Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added step to release pipeline to publish to neo4jlabs/neodash on Docker Hub (#299)

* Added new Docker image publish location

* Refactoring docs to point to new docker image location

* Fixed URL reference for gallery docs

* [Feature Request] Refresh button #166 (#277)

* [Feature Request] Refresh button #166

* [Feature Request] Refresh button #166

* Added conditional setting of last run timestamp

* Added option to turn on/off refreshing/download/fullscreening for each report

* enabled refreshing/fullscreening/image download on a per report basis

* Moved refresh rate, fullscreening, and screenshots to advanced settings for each report

* Disabled database selector for text/markdown reports

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump @neo4j-cypher/react-codemirror to pre 18 (#309)

* update @neo4j-cypher/react-codemirror for bugfix

fixes a bug where syntax highlighting markers weren't being cleared properly

* oops use ^ in package version

* bump again for pre-release 19

* condensed display for tables #167 (#278)

* condensed display for tables #167

* condensed display for tables #167

* #167 Fix half-displayed row in compact table

* Fix overflowing row for compact table

* Added safe boolean checking for compaction setting

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* update editor for minification bugfix (constructor.name) (#311)

* Fixed doc page title

* Added instructions on deploying a buildt to a webserver

* Isoa3, a2 and n3 support (#284)

* Isoa3, a2 and n3 support

* Changed choropleth polymap source to neodash repository

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Added error boundary for reports (#313)

* Added error boundary for reports

* Minor correction in README

* More small changes to the README

* More small changes to the README

* Added release notes, bumped version number

* Parameter Selector Display option (#274)

* Selector display vs value

* extra changes . some test changes

* Fix typo

* FIx on Parameter selec

* Minor style fixes

---------

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Feature/style with parameters (#330)

* StyleWithParams

* Stability fixes for rule-based styling on parameters

* Fix for rule-based styling in graph charts

---------

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Feature/rule based styling on top of scheme (#331)

* Added utils for chart colors and updated coloring function in PieChart component

* on bars

* Reuse existing color util instead of new one

---------

Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Refactoring the parameter selector chart and updating MUI component (#301)

* Refactoring the parameter selector chart and updating MUI component version

* Continued refactoring of parameter selector component

* Finished refactoring of parameters. Also fixed the weird bug where values were set incorrectly

* updated release notes

* Refactoring based on the new parameter display values

* Finished refactor and merging of parameter display setting

* Updated release notes again

* finalized changelog and release notes

* Fixed typo in about modal screen

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Bastien Hubert <43408420+bastienhubert@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil Menezes <37837480+skoarkid@users.noreply.github.com>
Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: alfredorubin96 <103421036+alfredorubin96@users.noreply.github.com>
Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: ioilmio <Illuminato.salvatore@gmail.com>
Co-authored-by: Jon Harris <harris.jb@gmail.com>
nielsdejong added a commit that referenced this pull request Feb 7, 2023
* Master to dev Release (#259)

* TableChart : Auto-hide columns prefixed with __

* Master to dev Release (#259)

* Added prettier (config based on neo4j/nx repository)

* Added eslint and husky (config based on neo4j/nx repository)

* Updated eslint config to be as light as possible with Typescript

* Updated all files with prettier and linter, refactored files to avoid errors

* Added Eslint check step in Github workflows

* Updated all files with prettier and linter after rebase on Develop branch

* Squash Security Bumbs (#281)

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump loader-utils from 1.4.0 to 1.4.2

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update yarn.lock

* yarn gallery util 3.2.1

* bump

* remove lodash 4.17.15 lock

* remove minimatch 3.0.4 lock

* remove d3 color lock

* remove node.fet color lock

* ut

* no node fetch

* lod

* lod2

* ncheck

* d3 init

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#264)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes #160 (#269)

* Fix : Replace parameter in iFrame URLs (#276)

* Fix : Replace parameter in iFrame URLs

* Fix wrong merge conflict

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#290)

* Bump loader-utils from 1.4.0 to 1.4.2 (#265)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Crash on Boolean options parameter selection (#285)

* bug on non string values

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Hotfix for Neo4j container issues with 5.3 (#293)

* Updated deployment scripts to use minimal build without source maps (#271)

* Changed build script to use mimimal (no source map) deployment

* Added TODOs based on comments

* Changing card image download logic  (#273)

* feature(): Changing download logic for card download by downloading the entire card instead of just the view. This kind of change adds also the buttons to the downloaded image, that is not ideal.

* fix(download report image): added missing ref for card expanded view

* Removed package-lock.json

Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Dynamic Card titles (#270)

* change of names

* Resolving conflicts

* Bug fix

* Refactoring

* Fixed replacement of params in card headers

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Docs on custom map provider (#282)

* Docs on custom map provider

* Update docs/modules/ROOT/pages/user-guide/reports/map.adoc

Co-authored-by: MariusC <marius.conjeaud@outlook.com>

Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added release notes, bumped version number

* Fixed style issues introduced by 2.2.1 + some of the console warnings in development mode

* Some more minor style fixes in modal text

* Fixed unclear phrasing in extensions modal

* Added wine dashboard to gallery (#298)

* Added wine dashboard

* Updated wine dashboard in gallery

* Added jokes dashboard (#300)

* Added citation graph (#306)

* Bump json5 from 1.0.1 to 1.0.2 (#302)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump json5 from 2.2.1 to 2.2.3 in /docs (#303)

Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump json5 from 1.0.1 to 1.0.2 in /gallery (#304)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added assessment gallery

* Bump convict from 6.2.3 to 6.2.4 in /docs (#307)

Bumps [convict](https://github.com/mozilla/node-convict) from 6.2.3 to 6.2.4.
- [Release notes](https://github.com/mozilla/node-convict/releases)
- [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mozilla/node-convict/commits)

---
updated-dependencies:
- dependency-name: convict
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* use link (#295)

add  a link to the neodash repo

* upgrade to @neo4j-cypher/react-codemirror package (#286)

* upgrade to neo4j-cypher/react-codemirror package

* bump @neo4j-cypher/react-codemirror

* remove unused old cypher editor component

* fix integration tests (missing className)

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror to latest

add codemirror markdown packages as an experiment

* enable switching between cypher/markdown languages

* update yarn.lock

* fix lint errors

* update @neo4j-cypher/react-codemirror to latest (fix line number text height)

* Fixed breaking integration tests

Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added step to release pipeline to publish to neo4jlabs/neodash on Docker Hub (#299)

* Added new Docker image publish location

* Refactoring docs to point to new docker image location

* Fixed URL reference for gallery docs

* [Feature Request] Refresh button #166 (#277)

* [Feature Request] Refresh button #166

* [Feature Request] Refresh button #166

* Added conditional setting of last run timestamp

* Added option to turn on/off refreshing/download/fullscreening for each report

* enabled refreshing/fullscreening/image download on a per report basis

* Moved refresh rate, fullscreening, and screenshots to advanced settings for each report

* Disabled database selector for text/markdown reports

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump @neo4j-cypher/react-codemirror to pre 18 (#309)

* update @neo4j-cypher/react-codemirror for bugfix

fixes a bug where syntax highlighting markers weren't being cleared properly

* oops use ^ in package version

* bump again for pre-release 19

* condensed display for tables #167 (#278)

* condensed display for tables #167

* condensed display for tables #167

* #167 Fix half-displayed row in compact table

* Fix overflowing row for compact table

* Added safe boolean checking for compaction setting

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* update editor for minification bugfix (constructor.name) (#311)

* Fixed doc page title

* Added instructions on deploying a buildt to a webserver

* Isoa3, a2 and n3 support (#284)

* Isoa3, a2 and n3 support

* Changed choropleth polymap source to neodash repository

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Added error boundary for reports (#313)

* Added error boundary for reports

* Minor correction in README

* More small changes to the README

* More small changes to the README

* Added release notes, bumped version number

* Parameter Selector Display option (#274)

* Selector display vs value

* extra changes . some test changes

* Fix typo

* FIx on Parameter selec

* Minor style fixes

---------

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Feature/style with parameters (#330)

* StyleWithParams

* Stability fixes for rule-based styling on parameters

* Fix for rule-based styling in graph charts

---------

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Feature/rule based styling on top of scheme (#331)

* Added utils for chart colors and updated coloring function in PieChart component

* on bars

* Reuse existing color util instead of new one

---------

Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Refactoring the parameter selector chart and updating MUI component (#301)

* Refactoring the parameter selector chart and updating MUI component version

* Continued refactoring of parameter selector component

* Finished refactoring of parameters. Also fixed the weird bug where values were set incorrectly

* updated release notes

* Refactoring based on the new parameter display values

* Finished refactor and merging of parameter display setting

* Updated release notes again

* finalized changelog and release notes

* Fixed typo in about modal screen

* Stacked Bars Colors Fix (#343)

* Stacked Bars COlors FIx

* Workaround source map warning

* No multicolor on singles

* fix on long lists

* Fixed bug in manual label name specification of param selector (#344)

* Passed all dashboard parameters to parameter populating query

* Bump http-cache-semantics from 4.1.0 to 4.1.1 (#334)

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Fix for numbers. (#346)

* Scatter plot (#341)

* Scatter plot

Add advanced setting to line charts to turn it into a scatter plot

* Scatter plot

Add advanced setting to line charts to turn it into a scatter plot

* Added docs and refactored settings retrieval

---------

Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Added release notes for 2.2.3 (#348)

* Added release notes for 2.2.3

* Added release notes for 2.2.3

* Added fix for link parsing in documentation portal

* Quickfix for auto-resetting param display text when advanced setting is toggled

* Updated release notes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Bastien Hubert <43408420+bastienhubert@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil Menezes <37837480+skoarkid@users.noreply.github.com>
Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: alfredorubin96 <103421036+alfredorubin96@users.noreply.github.com>
Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: ioilmio <Illuminato.salvatore@gmail.com>
Co-authored-by: Jon Harris <harris.jb@gmail.com>
Co-authored-by: Jon Ander Oribe <jonan.oribe@gmail.com>
nielsdejong added a commit that referenced this pull request Feb 7, 2023
* Master to dev Release (#259)

* TableChart : Auto-hide columns prefixed with __

* Master to dev Release (#259)

* Added prettier (config based on neo4j/nx repository)

* Added eslint and husky (config based on neo4j/nx repository)

* Updated eslint config to be as light as possible with Typescript

* Updated all files with prettier and linter, refactored files to avoid errors

* Added Eslint check step in Github workflows

* Updated all files with prettier and linter after rebase on Develop branch

* Squash Security Bumbs (#281)

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump loader-utils from 1.4.0 to 1.4.2

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update yarn.lock

* yarn gallery util 3.2.1

* bump

* remove lodash 4.17.15 lock

* remove minimatch 3.0.4 lock

* remove d3 color lock

* remove node.fet color lock

* ut

* no node fetch

* lod

* lod2

* ncheck

* d3 init

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#264)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes #160 (#269)

* Fix : Replace parameter in iFrame URLs (#276)

* Fix : Replace parameter in iFrame URLs

* Fix wrong merge conflict

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#290)

* Bump loader-utils from 1.4.0 to 1.4.2 (#265)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Crash on Boolean options parameter selection (#285)

* bug on non string values

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Hotfix for Neo4j container issues with 5.3 (#293)

* Updated deployment scripts to use minimal build without source maps (#271)

* Changed build script to use mimimal (no source map) deployment

* Added TODOs based on comments

* Changing card image download logic  (#273)

* feature(): Changing download logic for card download by downloading the entire card instead of just the view. This kind of change adds also the buttons to the downloaded image, that is not ideal.

* fix(download report image): added missing ref for card expanded view

* Removed package-lock.json

Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Dynamic Card titles (#270)

* change of names

* Resolving conflicts

* Bug fix

* Refactoring

* Fixed replacement of params in card headers

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Docs on custom map provider (#282)

* Docs on custom map provider

* Update docs/modules/ROOT/pages/user-guide/reports/map.adoc

Co-authored-by: MariusC <marius.conjeaud@outlook.com>

Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added release notes, bumped version number

* Fixed style issues introduced by 2.2.1 + some of the console warnings in development mode

* Some more minor style fixes in modal text

* Fixed unclear phrasing in extensions modal

* Added wine dashboard to gallery (#298)

* Added wine dashboard

* Updated wine dashboard in gallery

* Added jokes dashboard (#300)

* Added citation graph (#306)

* Bump json5 from 1.0.1 to 1.0.2 (#302)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump json5 from 2.2.1 to 2.2.3 in /docs (#303)

Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump json5 from 1.0.1 to 1.0.2 in /gallery (#304)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added assessment gallery

* Bump convict from 6.2.3 to 6.2.4 in /docs (#307)

Bumps [convict](https://github.com/mozilla/node-convict) from 6.2.3 to 6.2.4.
- [Release notes](https://github.com/mozilla/node-convict/releases)
- [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mozilla/node-convict/commits)

---
updated-dependencies:
- dependency-name: convict
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* use link (#295)

add  a link to the neodash repo

* upgrade to @neo4j-cypher/react-codemirror package (#286)

* upgrade to neo4j-cypher/react-codemirror package

* bump @neo4j-cypher/react-codemirror

* remove unused old cypher editor component

* fix integration tests (missing className)

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror to latest

add codemirror markdown packages as an experiment

* enable switching between cypher/markdown languages

* update yarn.lock

* fix lint errors

* update @neo4j-cypher/react-codemirror to latest (fix line number text height)

* Fixed breaking integration tests

Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Added step to release pipeline to publish to neo4jlabs/neodash on Docker Hub (#299)

* Added new Docker image publish location

* Refactoring docs to point to new docker image location

* Fixed URL reference for gallery docs

* [Feature Request] Refresh button #166 (#277)

* [Feature Request] Refresh button #166

* [Feature Request] Refresh button #166

* Added conditional setting of last run timestamp

* Added option to turn on/off refreshing/download/fullscreening for each report

* enabled refreshing/fullscreening/image download on a per report basis

* Moved refresh rate, fullscreening, and screenshots to advanced settings for each report

* Disabled database selector for text/markdown reports

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump @neo4j-cypher/react-codemirror to pre 18 (#309)

* update @neo4j-cypher/react-codemirror for bugfix

fixes a bug where syntax highlighting markers weren't being cleared properly

* oops use ^ in package version

* bump again for pre-release 19

* condensed display for tables #167 (#278)

* condensed display for tables #167

* condensed display for tables #167

* #167 Fix half-displayed row in compact table

* Fix overflowing row for compact table

* Added safe boolean checking for compaction setting

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* update editor for minification bugfix (constructor.name) (#311)

* Fixed doc page title

* Added instructions on deploying a buildt to a webserver

* Isoa3, a2 and n3 support (#284)

* Isoa3, a2 and n3 support

* Changed choropleth polymap source to neodash repository

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Added error boundary for reports (#313)

* Added error boundary for reports

* Minor correction in README

* More small changes to the README

* More small changes to the README

* Added release notes, bumped version number

* Parameter Selector Display option (#274)

* Selector display vs value

* extra changes . some test changes

* Fix typo

* FIx on Parameter selec

* Minor style fixes

---------

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Feature/style with parameters (#330)

* StyleWithParams

* Stability fixes for rule-based styling on parameters

* Fix for rule-based styling in graph charts

---------

Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Feature/rule based styling on top of scheme (#331)

* Added utils for chart colors and updated coloring function in PieChart component

* on bars

* Reuse existing color util instead of new one

---------

Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Refactoring the parameter selector chart and updating MUI component (#301)

* Refactoring the parameter selector chart and updating MUI component version

* Continued refactoring of parameter selector component

* Finished refactoring of parameters. Also fixed the weird bug where values were set incorrectly

* updated release notes

* Refactoring based on the new parameter display values

* Finished refactor and merging of parameter display setting

* Updated release notes again

* finalized changelog and release notes

* Fixed typo in about modal screen

* Stacked Bars Colors Fix (#343)

* Stacked Bars COlors FIx

* Workaround source map warning

* No multicolor on singles

* fix on long lists

* Fixed bug in manual label name specification of param selector (#344)

* Passed all dashboard parameters to parameter populating query

* Bump http-cache-semantics from 4.1.0 to 4.1.1 (#334)

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Fix for numbers. (#346)

* Scatter plot (#341)

* Scatter plot

Add advanced setting to line charts to turn it into a scatter plot

* Scatter plot

Add advanced setting to line charts to turn it into a scatter plot

* Added docs and refactored settings retrieval

---------

Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Niels de Jong <niels-121@hotmail.com>

* Added release notes for 2.2.3 (#348)

* Added release notes for 2.2.3

* Added release notes for 2.2.3

* Added fix for link parsing in documentation portal

* Quickfix for auto-resetting param display text when advanced setting is toggled

* Updated release notes

* Bumped Cypher editor version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Bastien Hubert <43408420+bastienhubert@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil Menezes <37837480+skoarkid@users.noreply.github.com>
Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: alfredorubin96 <103421036+alfredorubin96@users.noreply.github.com>
Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: ioilmio <Illuminato.salvatore@gmail.com>
Co-authored-by: Jon Harris <harris.jb@gmail.com>
Co-authored-by: Jon Ander Oribe <jonan.oribe@gmail.com>
@nielsdejong nielsdejong deleted the feature/parameterDisplay branch February 7, 2023 11:26
@nielsdejong nielsdejong mentioned this pull request Feb 11, 2023
nielsdejong added a commit that referenced this pull request Feb 11, 2023
* Master to dev Release (#259)

* TableChart : Auto-hide columns prefixed with __

* Master to dev Release (#259)

* Added prettier (config based on neo4j/nx repository)

* Added eslint and husky (config based on neo4j/nx repository)

* Updated eslint config to be as light as possible with Typescript

* Updated all files with prettier and linter, refactored files to avoid errors

* Added Eslint check step in Github workflows

* Updated all files with prettier and linter after rebase on Develop branch

* Squash Security Bumbs (#281)

* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...



* Bump loader-utils from 1.4.0 to 1.4.2

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...



* Update yarn.lock

* yarn gallery util 3.2.1

* bump

* remove lodash 4.17.15 lock

* remove minimatch 3.0.4 lock

* remove d3 color lock

* remove node.fet color lock

* ut

* no node fetch

* lod

* lod2

* ncheck

* d3 init





* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#264)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...






* Fixes #160 (#269)

* Fix : Replace parameter in iFrame URLs (#276)

* Fix : Replace parameter in iFrame URLs

* Fix wrong merge conflict



* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery (#290)

* Bump loader-utils from 1.4.0 to 1.4.2 (#265)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...






* Bump loader-utils from 2.0.2 to 2.0.4 in /gallery

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...







* Crash on Boolean options parameter selection (#285)

* bug on non string values

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts

* Fix merge conflicts



* Hotfix for Neo4j container issues with 5.3 (#293)

* Updated deployment scripts to use minimal build without source maps (#271)

* Changed build script to use mimimal (no source map) deployment

* Added TODOs based on comments

* Changing card image download logic  (#273)

* feature(): Changing download logic for card download by downloading the entire card instead of just the view. This kind of change adds also the buttons to the downloaded image, that is not ideal.

* fix(download report image): added missing ref for card expanded view

* Removed package-lock.json




* Dynamic Card titles (#270)

* change of names

* Resolving conflicts

* Bug fix

* Refactoring

* Fixed replacement of params in card headers



* Docs on custom map provider (#282)

* Docs on custom map provider

* Update docs/modules/ROOT/pages/user-guide/reports/map.adoc






* Added release notes, bumped version number

* Fixed style issues introduced by 2.2.1 + some of the console warnings in development mode

* Some more minor style fixes in modal text

* Fixed unclear phrasing in extensions modal

* Added wine dashboard to gallery (#298)

* Added wine dashboard

* Updated wine dashboard in gallery

* Added jokes dashboard (#300)

* Added citation graph (#306)

* Bump json5 from 1.0.1 to 1.0.2 (#302)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...







* Bump json5 from 2.2.1 to 2.2.3 in /docs (#303)

Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...






* Bump json5 from 1.0.1 to 1.0.2 in /gallery (#304)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...







* Added assessment gallery

* Bump convict from 6.2.3 to 6.2.4 in /docs (#307)

Bumps [convict](https://github.com/mozilla/node-convict) from 6.2.3 to 6.2.4.
- [Release notes](https://github.com/mozilla/node-convict/releases)
- [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mozilla/node-convict/commits)

---
updated-dependencies:
- dependency-name: convict
  dependency-type: indirect
...







* use link (#295)

add  a link to the neodash repo

* upgrade to @neo4j-cypher/react-codemirror package (#286)

* upgrade to neo4j-cypher/react-codemirror package

* bump @neo4j-cypher/react-codemirror

* remove unused old cypher editor component

* fix integration tests (missing className)

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror

* bump @neo4j-cypher/react-codemirror to latest

add codemirror markdown packages as an experiment

* enable switching between cypher/markdown languages

* update yarn.lock

* fix lint errors

* update @neo4j-cypher/react-codemirror to latest (fix line number text height)

* Fixed breaking integration tests



* Added step to release pipeline to publish to neo4jlabs/neodash on Docker Hub (#299)

* Added new Docker image publish location

* Refactoring docs to point to new docker image location

* Fixed URL reference for gallery docs

* [Feature Request] Refresh button #166 (#277)

* [Feature Request] Refresh button #166

* [Feature Request] Refresh button #166

* Added conditional setting of last run timestamp

* Added option to turn on/off refreshing/download/fullscreening for each report

* enabled refreshing/fullscreening/image download on a per report basis

* Moved refresh rate, fullscreening, and screenshots to advanced settings for each report

* Disabled database selector for text/markdown reports




* Bump @neo4j-cypher/react-codemirror to pre 18 (#309)

* update @neo4j-cypher/react-codemirror for bugfix

fixes a bug where syntax highlighting markers weren't being cleared properly

* oops use ^ in package version

* bump again for pre-release 19

* condensed display for tables #167 (#278)

* condensed display for tables #167

* condensed display for tables #167

* #167 Fix half-displayed row in compact table

* Fix overflowing row for compact table

* Added safe boolean checking for compaction setting




* update editor for minification bugfix (constructor.name) (#311)

* Fixed doc page title

* Added instructions on deploying a buildt to a webserver

* Isoa3, a2 and n3 support (#284)

* Isoa3, a2 and n3 support

* Changed choropleth polymap source to neodash repository



* Added error boundary for reports (#313)

* Added error boundary for reports

* Minor correction in README

* More small changes to the README

* More small changes to the README

* Added release notes, bumped version number

* Parameter Selector Display option (#274)

* Selector display vs value

* extra changes . some test changes

* Fix typo

* FIx on Parameter selec

* Minor style fixes

---------



* Feature/style with parameters (#330)

* StyleWithParams

* Stability fixes for rule-based styling on parameters

* Fix for rule-based styling in graph charts

---------



* Feature/rule based styling on top of scheme (#331)

* Added utils for chart colors and updated coloring function in PieChart component

* on bars

* Reuse existing color util instead of new one

---------




* Refactoring the parameter selector chart and updating MUI component (#301)

* Refactoring the parameter selector chart and updating MUI component version

* Continued refactoring of parameter selector component

* Finished refactoring of parameters. Also fixed the weird bug where values were set incorrectly

* updated release notes

* Refactoring based on the new parameter display values

* Finished refactor and merging of parameter display setting

* Updated release notes again

* finalized changelog and release notes

* Fixed typo in about modal screen

* Stacked Bars Colors Fix (#343)

* Stacked Bars COlors FIx

* Workaround source map warning

* No multicolor on singles

* fix on long lists

* Fixed bug in manual label name specification of param selector (#344)

* Passed all dashboard parameters to parameter populating query

* Bump http-cache-semantics from 4.1.0 to 4.1.1 (#334)

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...






* Fix for numbers. (#346)

* Scatter plot (#341)

* Scatter plot

Add advanced setting to line charts to turn it into a scatter plot

* Scatter plot

Add advanced setting to line charts to turn it into a scatter plot

* Added docs and refactored settings retrieval

---------




* Added release notes for 2.2.3 (#348)

* Added release notes for 2.2.3

* Added release notes for 2.2.3

* Added fix for link parsing in documentation portal

* Quickfix for auto-resetting param display text when advanced setting is toggled

* Updated release notes

* Bumped Cypher editor version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Harold Agudelo <agudeloharold13@gmail.com>
Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Bastien Hubert <43408420+bastienhubert@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil Menezes <37837480+skoarkid@users.noreply.github.com>
Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: alfredorubin96 <103421036+alfredorubin96@users.noreply.github.com>
Co-authored-by: Alfred Rubin <alfredo.rubin@neo4j.com>
Co-authored-by: ioilmio <Illuminato.salvatore@gmail.com>
Co-authored-by: Jon Harris <harris.jb@gmail.com>
Co-authored-by: Jon Ander Oribe <jonan.oribe@gmail.com>
@gcthys
Copy link

gcthys commented Feb 14, 2023

I think the new function interferes with the Report Actions. See last post on #241

@nielsdejong nielsdejong mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter select: queries do not distinguish between synonyms
4 participants