[gRNAet7B] Fixes trigger procedures in clusters for neo4j 5.x #250

vga91 · 2022-11-22T14:31:03Z

Cherry pick of [gRNAet7B] Fixes trigger procedures in clusters neo4j-contrib/neo4j-apoc-procedures#3183 ,
Fix flaky cluster test [gRNAet7B] Try fix flaky TriggerClusterRoutingTest neo4j-contrib/neo4j-apoc-procedures#3323
Fix other flakinesses [gRNAet7B] Try de-flaky some tests with new procedure triggers neo4j-contrib/neo4j-apoc-procedures#3355
Added trigger show procedure [gRNAet7B] Added trigger show procedure neo4j-contrib/neo4j-apoc-procedures#3335
cherry pick of https://github.com/neo4j-contrib/neo4j-apoc-procedures/pull/3369/files

Related docs pr: https://github.com/neo4j/docs-apoc/pull/56

full/src/test/java/apoc/trigger/TriggerNewProceduresExtendedTest.java

core/src/main/java/apoc/trigger/Trigger.java

core/src/main/java/apoc/trigger/TriggerNewProcedures.java

…4j-apoc-procedures#3323)

…cedures#3335) * Fix flaky trigger dbms availability tests * added apoc.trigger.show proc * retry to fix flaky test by separating setLastUpdate() * removed updated output - some code refactoring * split pr - changes review * removed inner transaction * updated documentation * reset wrong generated docs * Added admin in trigger.show * small adoc changes

…-contrib/neo4j-apoc-procedures#3355) * Try de-flaky some tests with new procedure triggers * moved TriggerTestUtil and increased trigger.refresh value * added waitDbsAvailable util

…cated ones (neo4j-contrib/neo4j-apoc-procedures#3325) * [gRNAet7B] added trigger new procs documentation * changes review - procedure description * changed listener wording * added system db note * var. small changes

* [coZSswV2] Fix typo in triggers error message * [coZSswV2] Assert new triggers can't add TransactionEventListeners to "system" * [coZSswV2] Assert old triggers can't add TransactionEventListeners to "system"

…-procedures#3357) * [qwJFy8pp] Add @Admin to trigger procedures * added admin in trigger.list and docs note * changed admin doc

…3378)

…on db check

… ones

AzuObs

Thank you so much for all the hard work. It looks great 💃

* [gRNAet7B] Changes from neo4j/apoc#250 * [gRNAet7B] Changed AtomicReference with 1-elem array

vga91 added cherry-picked dev labels Nov 22, 2022

vga91 marked this pull request as draft November 22, 2022 14:31

vga91 force-pushed the dev-fix-trigger-procedures branch 3 times, most recently from 99044fc to e4669fa Compare November 22, 2022 21:31

vga91 mentioned this pull request Nov 22, 2022

[gRNAet7B] Fixes trigger procedures in clusters for neo4j 5.x (extended part) neo4j-contrib/neo4j-apoc-procedures#3330

Closed

vga91 force-pushed the dev-fix-trigger-procedures branch from d4608d4 to 05098f6 Compare November 23, 2022 08:18

vga91 marked this pull request as ready for review November 23, 2022 08:54

vga91 force-pushed the dev-fix-trigger-procedures branch 2 times, most recently from cff9027 to 5e92364 Compare December 15, 2022 15:22

vga91 removed the cherry-picked label Dec 15, 2022

vga91 force-pushed the dev-fix-trigger-procedures branch from 5e92364 to 1a0c361 Compare December 16, 2022 08:02

Lojjs assigned AzuObs Dec 16, 2022

vga91 force-pushed the dev-fix-trigger-procedures branch from cacdf54 to 0284596 Compare December 16, 2022 16:21

vga91 mentioned this pull request Dec 20, 2022

[hDJkPkOQ] Add QueryType validation in apoc.trigger.add #214

Closed

AzuObs reviewed Dec 20, 2022

View reviewed changes

full/src/test/java/apoc/trigger/TriggerNewProceduresExtendedTest.java Outdated Show resolved Hide resolved

AzuObs reviewed Dec 20, 2022

View reviewed changes

core/src/main/java/apoc/trigger/Trigger.java Outdated Show resolved Hide resolved

AzuObs reviewed Dec 20, 2022

View reviewed changes

core/src/main/java/apoc/trigger/Trigger.java Show resolved Hide resolved

vga91 force-pushed the dev-fix-trigger-procedures branch 4 times, most recently from 26cb203 to f1e0e98 Compare December 22, 2022 17:13