Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6uBw3vO1] Enable core test CI #279

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jan 10, 2023

  • removed Assumes
  • removed duplicated GenericContainer httpServer
  • changed SpatialTest to make sure signatures are equivalents with the real ones.
  • changed shouldNotQuoteWhenAvoidQuoteIsTrue() in UtilQuoteTest
  • removed fixed port numbers
  • removed some Assert.assertTrue("Neo4j Instance should be up-and-running"..., they shouldn't be needed as the test would fail sooner, and to be consistent with Extended where they are not present
  • fixed ApocSplitTest.test()

@vga91 vga91 force-pushed the fail-tests-if-dependencies-fail-apoc-core branch 5 times, most recently from 47dcb2e to c4acfea Compare January 12, 2023 16:22
@vga91 vga91 changed the title [6uBw3vO1] [WIP] Fail tests if dependencies fail apoc core [6uBw3vO1] [WIP] Enable core test CI Jan 13, 2023
@vga91 vga91 force-pushed the fail-tests-if-dependencies-fail-apoc-core branch from 4c6d4a8 to cdbe51f Compare January 22, 2023 15:25
@vga91 vga91 force-pushed the fail-tests-if-dependencies-fail-apoc-core branch 5 times, most recently from 7ae2fc7 to 7637460 Compare January 22, 2023 23:55
@vga91 vga91 force-pushed the fail-tests-if-dependencies-fail-apoc-core branch from 7637460 to 1300b45 Compare January 23, 2023 07:36
@vga91 vga91 changed the title [6uBw3vO1] [WIP] Enable core test CI [6uBw3vO1] Enable core test CI Jan 23, 2023
@ncordon ncordon force-pushed the fail-tests-if-dependencies-fail-apoc-core branch 2 times, most recently from a491e8b to 304c914 Compare February 7, 2023 14:41
@ncordon ncordon force-pushed the fail-tests-if-dependencies-fail-apoc-core branch from 868c5f3 to a972ad5 Compare February 8, 2023 12:36
@ncordon ncordon merged commit 5a19d13 into dev Feb 8, 2023
@ncordon ncordon deleted the fail-tests-if-dependencies-fail-apoc-core branch February 8, 2023 13:15
ncordon pushed a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants