[ROQ0fkdz] Reduce the number of transactions we use in triggers

[vga91]

The ideal solution I suppose is to use @Context public Transaction tx, which calls ProcedureTransactionImpl.

But with both this and @Context publicGraphDatabaseAPI [which calls ProcedureGraphDatabaseAPI] via db.beginTx(),

I receive the following error if I login with an user with role admin
(both with the embedded db and with an enterprise instance):

Creating new node label on database 'system' is not allowed for user '' 
with FULL overridden by READ overridden by READ. See GRANT CREATE NEW NODE LABEL ON DATABASE system

Btw, even trying to explicit GRANT CREATE NEW NODE LABEL ON DATABASE system TO admin gives the same result.

I also tried changing mode = Mode.WRITE to Mode.DBMS but it doesn't change anything.

I think the above one might be a bug, or so, not APOC related.

---

The only working way is to use @Context public GraphDatabaseAPI, which calls GraphDatabaseFacade.

[ncordon]

For these two you don't need to create a new transaction, you can just recycle the one you are in, so I'd suggest reshaping it like:

        checkInSystemWriter();
        checkTargetDatabase(databaseName);
        Map<String,Object> params = (Map)config.getOrDefault("params", Collections.emptyMap());

        return withTransaction(tx -> {
            TriggerInfo triggerInfo = TriggerHandlerNewProcedures.install(databaseName, name, statement, selector, params, tx);
            return Stream.of(triggerInfo);
        });

so you only open a new system transaction at the moment where you need it

[vga91]

Changed 👍