Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iTwFvqQ2] apoc.create.clonePathsToVirtual() returns more relationships than it should #328

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Feb 15, 2023

Added cache for apoc.create.clonePathsToVirtual in order to reuse the same virtual rel if already present,
so we don't visualize multiple relationships

Copy link
Contributor

@nadja-muller nadja-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good. It would be nice to simplify the test a bit.

core/src/test/java/apoc/create/CreateTest.java Outdated Show resolved Hide resolved
core/src/test/java/apoc/create/CreateTest.java Outdated Show resolved Hide resolved
core/src/test/java/apoc/create/CreateTest.java Outdated Show resolved Hide resolved
core/src/test/java/apoc/create/CreateTest.java Outdated Show resolved Hide resolved
@vga91 vga91 force-pushed the clonePathsToVirtual-duplicate-rels branch from df415d4 to d3fa326 Compare March 6, 2023 08:22
@vga91 vga91 merged commit fff90a4 into dev Mar 6, 2023
@vga91 vga91 deleted the clonePathsToVirtual-duplicate-rels branch March 6, 2023 10:17
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this pull request Mar 7, 2023
…ps than it should (neo4j/apoc#328)

* [iTwFvqQ2] apoc.create.clonePathsToVirtual() returns more relationships than it should

* [iTwFvqQ2] simplify test
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this pull request Mar 8, 2023
…ps than it should (neo4j/apoc#328) (#3481)

* [iTwFvqQ2] apoc.create.clonePathsToVirtual() returns more relationships than it should

* [iTwFvqQ2] simplify test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants