[bJ4pn0Bj] PeriodicTest.testTerminateCommit is flaky #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
fix-flaky-testTerminateCommit
branch
from
84cb78c
to
8fadc48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't notice it at first glance because locally it works even without the fix.
However the inner query was wrong because it returned a node, instead it is supposed to return a long.
My guess is that it's a timing problem, because if for example we remove the
limit 1000the query fails almost immediately,while with
return ninstead ofreturn count(n)it fails after a while.So probably doing
markForTermination()almost at the same time as it fails causes the flaky assertion error.