[OnEGwZ5A] apoc.hashing.fingerprint can't deal with type byte[] #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
apoc.hashing.fingerprint-bytearray
branch
from
530a36d
to
8886913
Compare
nadja-muller
approved these changes
Feb 20, 2023
| @@ -320,6 +320,10 @@ private String nativeArrayToString(Object value) { | |||
| for (double l : (long[]) value) { | |||
There was a problem hiding this comment.
Not part of this PR, but isnt that a lossy conversion? Shouldn't this be a long?
If so, we should probably fix it on another PR. What do you think?
There was a problem hiding this comment.
Yes definitely.
I created a card for it: https://trello.com/b/hCxd1VYs/apoc-core,
also to check if there are other wrong conversions around here
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Mar 7, 2023
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Mar 7, 2023
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[OnEGwZ5A] apoc.hashing.fingerprint can't deal with type byte[]