[3QAbWQds] apoc.export.arrow.all ignores export file config #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
reviewed
Mar 15, 2023
| // since it says "... use the `{stream:true}` config", but with arrow procedures the streaming mode is implemented via different procedures | ||
| if (!apocConfig().getBoolean(APOC_EXPORT_FILE_ENABLED)) { | ||
| throw new RuntimeException(EXPORT_TO_FILE_ARROW_ERROR); | ||
| } |
There was a problem hiding this comment.
Do we not have restrictions on where the file can be written to as well?
There was a problem hiding this comment.
Indeed the procedure is not so tested about these cases.
I added an ExportArrowSecurityTest file
similar to ExportCoreSecurityTest, to test all these cases.
I preferred to create a separate file, instead of adding the procedures in ExportCoreSecurityTest,
because it works too differently (parameter order, {stream:true} not present, etc..)
vga91
force-pushed
the
apoc.export.arrow.all-check-apoc-config
branch
from
3e3119e
to
108576f
Compare
vga91
force-pushed
the
apoc.export.arrow.all-check-apoc-config
branch
from
108576f
to
3d34341
Compare
vga91
added a commit
that referenced
this pull request
Apr 12, 2023
* [3QAbWQds] apoc.export.arrow.all ignores export file config * [3QAbWQds] Added ExportArrowSecurityTest and removed some unnecessary tests
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Jun 7, 2023
…oc#349) * [3QAbWQds] apoc.export.arrow.all ignores export file config * [3QAbWQds] Added ExportArrowSecurityTest and removed some unnecessary tests
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Jun 7, 2023
…oc#349) * [3QAbWQds] apoc.export.arrow.all ignores export file config * [3QAbWQds] Added ExportArrowSecurityTest and removed some unnecessary tests
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for procedures using file mode