[NOID] Making PeriodicTest more lenient #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ncordon
approved these changes
Mar 21, 2023
Co-authored-by: Gem Lamont <gemma.lamont@neotechnology.com>
arnefischereit
force-pushed
the
lenient-periodic-test
branch
from
9fdf4cf
to
299e6fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The test
PeriodicTesthas been very strict about what error message to expect from the parser. This restricts us in changing the parser while it brings very little value to the user.This change therefore proposes to only test for the relevant parts of the error message.
Co-authored-by: Gem Lamont gemma.lamont@neotechnology.com