Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOID] Bump commoms lang3 from 3.12.0 to 3.13.0 #473

Merged
merged 1 commit into from Aug 9, 2023
Merged

[NOID] Bump commoms lang3 from 3.12.0 to 3.13.0 #473

merged 1 commit into from Aug 9, 2023

Conversation

Lojjs
Copy link
Contributor

@Lojjs Lojjs commented Aug 9, 2023

Bump commons version to align the new version with the coming version of commons in core db: https://github.com/neo-technology/neo4j/pull/21746. Replaces #472

@Lojjs
[NOID] Bump commoms lang3 from 3.12.0 to 3.13.0
4874897 
Also update other licenses to match Neo4j.
@Lojjs Lojjs mentioned this pull request Aug 9, 2023
Closed
MishaDemianenko
MishaDemianenko approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@MishaDemianenko MishaDemianenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my commons-lang3 perspective. There are some license related build failures otherwise

@Lojjs
Copy link
Contributor Author

Lojjs commented Aug 9, 2023

Looks good from my commons-lang3 perspective. There are some license related build failures otherwise

That is because it is building towards Neo4j without your changes. I built locally towards your Neo4j PR and then it was green

@MishaDemianenko
Copy link
Contributor

Looks good from my commons-lang3 perspective. There are some license related build failures otherwise

That is because it is building towards Neo4j without your changes. I built locally towards your Neo4j PR and then it was green

Ah ok, in that case, how I should go with merging those 2 things?
My proposal: will do that in the evening and will merge neo pr and this one and trigger pipeline. Even if there will be a moment of failure since that will be in the evening there should be minimal impact. Wdyt?

@MishaDemianenko MishaDemianenko merged commit 22d45bc into dev Aug 9, 2023
12 of 14 checks passed
@MishaDemianenko MishaDemianenko deleted the 5.12-bump-cl branch August 9, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishaDemianenko MishaDemianenko MishaDemianenko approved these changes

@nadja-muller nadja-muller nadja-muller approved these changes

Assignees

@nadja-muller nadja-muller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lojjs @MishaDemianenko @nadja-muller