[1F4aew1T] Uses slf4j-api 2.x api instead of slf4j-simple 1.x #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
force-pushed
the
upgrade-slf4j-api-logger
branch
from
9094d3d
to
778ec55
Compare
Lojjs
reviewed
Aug 23, 2023
| @@ -64,6 +64,8 @@ public void check_basic_deployment() { | |||
| assertTrue(functionCount > 0); | |||
| assertTrue(coreCount > 0); | |||
| // Check there's one and only one logger for apoc inside the container | |||
| // and it doesn't override the one inside the database | |||
| assertFalse(startupLog.contains("[main] INFO org.eclipse.jetty.server.Server")); | |||
There was a problem hiding this comment.
Looking on the two log output versions in the descriptions of this PR, both contains this?
There was a problem hiding this comment.
Sorry I misread the ticket https://trello.com/c/1F4aew1T, the output does not have to appear at all, which is what this test is checking. I've updated the PR description.
Lojjs
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Because the logger was colliding with the jetty one included in coredb, showing output like: