Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gc8EZpDO] Clean up some usages of getId() which is deprecated #499

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

gem-neo4j
Copy link
Contributor

@gem-neo4j gem-neo4j commented Sep 27, 2023

getId() is deprecated, so slowly clearing it out of APOC, here are some more usage removals as well as some general tidy up 🧹

Docs: https://github.com/neo4j/docs-apoc/pull/202

@gem-neo4j gem-neo4j force-pushed the dev_update_node_id branch 2 times, most recently from 2bc733e to cb9334e Compare September 28, 2023 07:52
@gem-neo4j gem-neo4j marked this pull request as ready for review September 28, 2023 10:01
@Lojjs Lojjs self-assigned this Sep 29, 2023
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing tests for elementId for apoc.algo.cover and apoc.refactor.collapseNode, otherwise it looks fine

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@gem-neo4j gem-neo4j merged commit b762a88 into dev Oct 2, 2023
14 checks passed
@gem-neo4j gem-neo4j deleted the dev_update_node_id branch October 2, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants