[x2fDvuKu] extend timeout for flaky BigGraphTest #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadja-muller
force-pushed
the
fix-flaky-big-graph-test
branch
from
f1f93c7
to
b1c197c
Compare
nadja-muller
force-pushed
the
fix-flaky-big-graph-test
branch
from
b1c197c
to
bd54c04
Compare
ncordon
approved these changes
Oct 6, 2023
|
Closing since the frequency of the test failure is less than 1 in a 1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apoc.refactor.rename.type reuses functionality from periodic iterate, which uses a termination guard. However, there is no concrete guarantee on when we will catch it. I propose we extended the timemout to encompass the outlier in the build. The default value was 10L seconds.
When running the test locally, timepassed was 0. Doubles could be a bit more precise.