[q3KTZ83O] Remove strange clean up method #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_fix_double_quoting_issues_export_csv
branch
from
026e9aa
to
06bccbf
Compare
loveleif
reviewed
Oct 27, 2023
| @@ -196,7 +196,7 @@ private void writeNodesBulkImport(Reporter reporter, ExportConfig config, Export | |||
| return joinLabels(entrySet.getKey(), config.getArrayDelim()); | |||
| } | |||
| String prop = s.split(":")[0]; | |||
| return "".equals(prop) ? String.valueOf(getNodeId(tx, n.getElementId())) : cleanPoint(FormatUtils.toString(n.getProperty(prop, ""))); | |||
| return prop.isEmpty() ? String.valueOf(getNodeId(tx, n.getElementId())) : FormatUtils.toString(n.getProperty(prop, "")); | |||
There was a problem hiding this comment.
I believe the condition prop.isEmpty() can never be false?
scala> val prop = "".split(":")
val prop: Array[String] = Array("")
scala> prop.isEmpty
val res1: Boolean = false
There was a problem hiding this comment.
Oh, sorry, I didn't see the [0] part.
There was a problem hiding this comment.
But prop is not a list, it is a string because it takes the first element:
String prop = s.split(":")[0]; // Note the [0]
Comment on lines
-236
to
-241
| private String cleanPoint(String point) { | ||
| point = point.replace(",\"z\":null", ""); | ||
| point = point.replace(",\"heigth\":null", ""); | ||
| point = point.replace("\"", ""); | ||
| return point; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow double quotes in node and rel properties with export csv.
Automatic is quote: always, so now using bulkImport everything is super quoted, but it matches how not using bulkImport works :)