Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOID] Adds job to apply formatting in PRs #520

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[NOID] Adds job to apply formatting in PRs #520

merged 1 commit into from
Nov 3, 2023

Conversation

ncordon
Copy link
Collaborator

@ncordon ncordon commented Nov 1, 2023

What

Adds a job to run formatting in PRs by writting /spotlessApply in it

Why

Because especially for the licensing it's really annoying to have to update neo4j locally every time the license check fails 馃槩 . Doing a job for the licensing from this one is super easy, this has been done in a very reusable way. Most of the code is copied from the job we have in the monorepo.

@ncordon ncordon added the NOT READY FOR MERGE PR isn't ready to be merged label Nov 1, 2023
@ncordon ncordon changed the title Adds job to apply formatting in PRs [NOID] Adds job to apply formatting in PRs Nov 1, 2023
@ncordon ncordon force-pushed the format-bot branch 3 times, most recently from d52cbce to e58d887 Compare November 2, 2023 13:54
@ncordon ncordon added enhancement New feature or request and removed NOT READY FOR MERGE PR isn't ready to be merged labels Nov 2, 2023
Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :)

Do you plan to make the spotlessApply formatting do more than just unused imports?

@ncordon
Copy link
Collaborator Author

ncordon commented Nov 3, 2023

Do you plan to make the spotlessApply formatting do more than just unused imports?

Yeah, in another PR so we can test out this 馃槃

@ncordon ncordon merged commit 1a9a4af into dev Nov 3, 2023
14 checks passed
@ncordon ncordon deleted the format-bot branch November 3, 2023 14:30
@ncordon ncordon mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants