[NOID] Use Injected UrlAccessChecker for checking access to URLs #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
loveleif
approved these changes
Nov 23, 2023
Comment on lines
+50
to
+51
| @Context | ||
| public URLAccessChecker urlAccessChecker; |
There was a problem hiding this comment.
I assume this breaks backwards compatibility, but that's ok perhaps.
There was a problem hiding this comment.
Yeah, it does. But that's okay, right - we require a matching APOC version with each Neo4j release? How would we usually go about merging something that breaks like this? Core first, then APOC?
mnd999
force-pushed
the
dev-use-injected-urlchecker
branch
from
07ed483
to
e804174
Compare
…ead of calling internal WebURLAccessRule directly
mnd999
force-pushed
the
dev-use-injected-urlchecker
branch
from
e804174
to
ca9b2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<Replace with the number of the issue, Mandatory>
Use Injected URLAccessChecker for checking access to URLs calling internal WebURLAccessRule directly
Proposed Changes (Mandatory)
Inject a new URLAccessChecker to separate out APOC from making internal calls into WebURLAccessRule, as this needs to changes to support RBAC permissions as well. Having this injectable will mean that we can late get this new functionality in APOC as well for free.
The alternative is to move the config only based checks into APOC.