[HTtgtRFX] Fix bug in triggers #547
Conversation
loveleif
changed the title
| } | ||
| } | ||
|
|
||
| record DropRandomTriggers(Driver driver, String db, int iterations) implements Runnable { |
There was a problem hiding this comment.
Note, before we dropped triggers at random concurrently to creating them. I see no reason why that should not be possible. But since install trigger failed sometimes (EntityNotFound) I change it here to not drop and install at the same time. The important thing is that existing triggers run while we add and remove others, and that is still covered.
There was a problem hiding this comment.
Maybe I am just a bit slow this afternoon, but I'm a little confused as to how this is working, so in order it creates the Triggers, but deletes them randomly, so it may delete a trigger that isn't yet created? and won't delete all of them I guess?
I guess that is fine, just trying to think through the logic :)
There was a problem hiding this comment.
It's not the clearest test, but it was really good at reproducing a previous bug. Your statements are correct. The randomness does not serve that much purpose now. I guess I kept it to have some triggers live on for different amounts of time in case that makes a difference.
| } | ||
| } | ||
|
|
||
| record DropRandomTriggers(Driver driver, String db, int iterations) implements Runnable { |
There was a problem hiding this comment.
Maybe I am just a bit slow this afternoon, but I'm a little confused as to how this is working, so in order it creates the Triggers, but deletes them randomly, so it may delete a trigger that isn't yet created? and won't delete all of them I guess?
I guess that is fine, just trying to think through the logic :)
TriggerEnterpriseFeaturesTest.stressTest. I can't find anything wrong with the assertions, but they sometimes causedEntityNotFoundExceptionduring installing of triggers and hopefully this helps.