Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tyXNOmR9] Investigate flaky test #560

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[tyXNOmR9] Investigate flaky test #560

merged 2 commits into from
Dec 28, 2023

Conversation

loveleif
Copy link
Contributor

@loveleif loveleif commented Dec 27, 2023 •
edited

  • Improve assertion to investigate flaky test, instead of saying "false was not equal to true" it will report the full stack trace and error message.
  • Increase timeout.

AzuObs
AzuObs approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@AzuObs AzuObs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work

@loveleif loveleif merged commit e3922fd into dev Dec 28, 2023
20 checks passed
@loveleif loveleif deleted the flaky-osm branch December 28, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzuObs AzuObs AzuObs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loveleif @AzuObs