Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8cS8e3IT] Optimise apoc.meta.* procedures #589

Merged
merged 5 commits into from
Feb 21, 2024
Merged

[8cS8e3IT] Optimise apoc.meta.* procedures #589

merged 5 commits into from
Feb 21, 2024

Conversation

loveleif
Copy link
Contributor

@loveleif loveleif commented Feb 19, 2024 •
edited

Optimize apoc.meta.* by using internal kernel APIs instead of inner queries.

657x speedup 馃挩 in the added benchmark (from 2 ops/s to 1314 ops/s).

@loveleif loveleif changed the title Meta stats slow [8cS8e3IT] Optimise apoc.meta.* procedures Feb 20, 2024
@loveleif loveleif force-pushed the meta-stats-slow branch 6 times, most recently from 1892973 to 38eb219 Compare February 20, 2024 08:47
@loveleif loveleif marked this pull request as ready for review February 20, 2024 08:50
gem-neo4j
gem-neo4j approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice to have a benchmark in APOC! I am not very knowledgable about benchmarks, did you just run it locally? or how did you test it? :)

core/src/main/java/apoc/convert/Json.java Outdated Show resolved Hide resolved
settings.gradle Outdated Show resolved Hide resolved
@loveleif
Copy link
Contributor Author

I am not very knowledgable about benchmarks, did you just run it locally? or how did you test it? :)

Yes, ran it locally (./gradlew jmh)

@loveleif loveleif merged commit fe271e2 into dev Feb 21, 2024
20 checks passed
@loveleif loveleif deleted the meta-stats-slow branch February 21, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gem-neo4j gem-neo4j gem-neo4j approved these changes

Assignees

@gem-neo4j gem-neo4j

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loveleif @gem-neo4j