[oIVz2Y7V] apoc.refactor.cloneNodes does not need to be in its own transaction #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_remove_inner_tx_cloneNodes
branch
from
b1e0788
to
849e692
Compare
loveleif
approved these changes
Feb 28, 2024
Comment on lines
+172
to
+173
| List<Label> labels = getLabels(node); | ||
| return labels.toArray(new Label[0]); |
There was a problem hiding this comment.
You can go directly from stream to array
Suggested change
| List<Label> labels = getLabels(node); | |
| return labels.toArray(new Label[0]); | |
| return getLabelsAsStream(node).toArray(i -> new Label[i]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a github issue where a user complained that if the Cypher query failed after this procedure ran, the procedure itself still committed the result. This is because it opened new transactions inside, this seemed overkill, so removed that from happening.