[3yfKdDEx] Give a clear error message when a relationship is defined before its node #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_graphml_descriptive_error_message
branch
from
ee3753b
to
58bd6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a relationship in a graphml file are defined before the nodes they reference, a null error is thrown which is not very descriptive. So this updates it to make it clearer.
Note, I looked into holding off and continuing with the nodes and coming back to the missed relationship, but it gets complicated because the file is read line by line and the properties etc are part of this. But let me know if you think we should be doing that approach instead. It is doable, but I am not sure of the use case (as this is the first issue finding this).