Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalize function #312

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Add normalize function #312

merged 1 commit into from
Feb 29, 2024

Conversation

angrykoala
Copy link
Member

Add support for normalize function:

Cypher.normalize(new Cypher.Param("my string"), "NFC");

@angrykoala angrykoala linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 3060a56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/cypher-builder Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Feb 29, 2024

@@ -40,6 +41,18 @@ export function lTrim(original: Expr): CypherFunction {
return new CypherFunction("lTrim", [original]);
}

/**
* @see [Cypher Documentation](https://neo4j.com/docs/cypher-manual/current/functions/string/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon https://neo4j.com/docs/cypher-manual/current/functions/string/#functions-normalize would be the more accurate (as this one covers both), but then for consistency we should update all the links of each individual function here 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon https://neo4j.com/docs/cypher-manual/current/functions/string/#functions-normalize would be the more accurate (as this one covers both), but then for consistency we should update all the links of each individual function here 😅

Oh I see, yeah maybe so in a different PR?

Copy link
Member Author

@angrykoala angrykoala Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, tbh we need to give a bit of thought to these links.

I added them because I think it is a great documentation tool to have these links in the editor, but we have no guarantee that these links will remain up (in fact, I'm sure some of these links are already broken)

@angrykoala angrykoala merged commit 4a8621a into main Feb 29, 2024
10 checks passed
@angrykoala angrykoala deleted the 311-normalize-function branch February 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize function
2 participants