-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add normalize function #312
Conversation
🦋 Changeset detectedLatest commit: 3060a56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@@ -40,6 +41,18 @@ export function lTrim(original: Expr): CypherFunction { | |||
return new CypherFunction("lTrim", [original]); | |||
} | |||
|
|||
/** | |||
* @see [Cypher Documentation](https://neo4j.com/docs/cypher-manual/current/functions/string/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially https://neo4j.com/docs/cypher-manual/current/functions/string/#functions-normalize-with-normal-form is the more correct URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon https://neo4j.com/docs/cypher-manual/current/functions/string/#functions-normalize would be the more accurate (as this one covers both), but then for consistency we should update all the links of each individual function here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon https://neo4j.com/docs/cypher-manual/current/functions/string/#functions-normalize would be the more accurate (as this one covers both), but then for consistency we should update all the links of each individual function here 😅
Oh I see, yeah maybe so in a different PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, tbh we need to give a bit of thought to these links.
I added them because I think it is a great documentation tool to have these links in the editor, but we have no guarantee that these links will remain up (in fact, I'm sure some of these links are already broken)
Add support for
normalize
function: