Allow chaining statements to yielding calls. #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test and add the new interface for those kinda calls / chains you are missing. |
|
|
See spring-projects/spring-data-neo4j#2895 To get a build, use |
| @@ -79,7 +71,7 @@ public static FunctionInvocation id(@NotNull Node node) { | |||
| @NotNull @Contract(pure = true) | |||
| @Deprecated(since = "2023.3.0") | |||
| @SuppressWarnings({ "squid:S1133" }) // Yes, I promise, this will be removed at some point, but not yet. | |||
| public static FunctionInvocation id(@NotNull Relationship relationship) { | |||
| static FunctionInvocation id(@NotNull Relationship relationship) { | |||
There was a problem hiding this comment.
This could get already removed because there is no access to this method anymore, in contrast to the id(Node node) version that is used by the AbstractNode.
neo4j-cypher-dsl/src/main/java/org/neo4j/cypherdsl/core/DefaultStatementBuilder.java
Outdated
Show resolved
Hide resolved
neo4j-cypher-dsl/src/main/java/org/neo4j/cypherdsl/core/OngoingListBasedPredicateFunction.java
Outdated
Show resolved
Hide resolved
Make the yielding call return statement, but that would require a major change. So use this opportunity to remove all teh deprecations. Build will fail now as we did not make SDN aware of this in time (bummer)
…gListBasedPredicateFunction.java Co-authored-by: Gerrit Meier <meistermeier@gmail.com>
…tStatementBuilder.java Co-authored-by: Gerrit Meier <meistermeier@gmail.com>
michael-simons
force-pushed
the
feat/chaining
branch
from
290eb0d
to
5e05e69
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.