added possibility to set default_advertised_address through environment variable #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unterstein
changed the title
srbaker
suggested changes
Nov 28, 2016
| @@ -42,6 +42,9 @@ if [ "$1" == "neo4j" ]; then | |||
| setting "dbms.connector.https.listen_address" "0.0.0.0:7473" | |||
| setting "dbms.connector.bolt.listen_address" "0.0.0.0:7687" | |||
| setting "dbms.mode" "${NEO4J_dbms_mode:-}" | |||
| if [ -n "$NEO4J_dbms_advertisedAddress" ]; then | |||
There was a problem hiding this comment.
We've started using a convention for future improvements, so this variable should be NEO4J_dbms_connectors_defaultAdvertisedAddress.
Also, by using a default value as on the next line, you should be able to get rid of the if statement like so:
setting "dbms.connectors.default_advertised_address" "${NEO4J_dbms_connectors_defaultAdvertisedAddress:-}"
After you make those changes and test it, I'll be happy to merge it quickly.
Thanks for your contribution!
There was a problem hiding this comment.
Hi,
thanks for your feedback. Is this ok?
Cheers
srbaker
approved these changes
Nov 28, 2016
|
Perfect, thanks! I'll get this merged tomorrow (Europe time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
My intention:
In order to support networking features like overlay networks and virtual IPs, it would be great if
dbms.connectors.default_advertised_addresswould be configurable. It would be great, if it would be possible to inject the advertised addressed from the outside, for example usingNEO4J_dbms_advertisedAddressenvironment variable.This property should only be set, if the environment variable is set.
I compared the neo4j.conf in 2.3 and 3.0 branch and did not found
dbms.connectors.default_advertised_addressproperty, therefore I only added this configuration only in 3.1 and 3.2.