Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to database requirements in requirements for tutorial #942

Merged
merged 3 commits into from Feb 9, 2022

Conversation

catherineluse
Copy link
Contributor

Description

This docs change would have prevented me from running into problems with creating nodes with DateTimes.

Issue

Please provide a link to the GitHub issue in which the proposal for this work was discussed below.

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@darrellwarde darrellwarde changed the base branch from master to dev February 7, 2022 20:40
@darrellwarde darrellwarde changed the base branch from dev to master February 7, 2022 20:40
darrellwarde
darrellwarde previously approved these changes Feb 8, 2022
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @catherineluse! We'd normally merge changes like this into dev, however, on this occasion a merge from master into dev will be happening tomorrow at the latest, so this isn't such a big deal.

@darrellwarde darrellwarde self-requested a review February 8, 2022 13:51
@darrellwarde
Copy link
Contributor

One thing I do have to ask before merging - I don't see your CLA email. Have you signed our CLA? https://neo4j.com/developer/cla/#sign-cla

@darrellwarde darrellwarde added this to Inbox in PR Triage Feb 8, 2022
@darrellwarde darrellwarde moved this from Inbox to Community in PR Triage Feb 8, 2022
@darrellwarde darrellwarde moved this from Community to High Priority (Community) in PR Triage Feb 8, 2022
@darrellwarde darrellwarde self-assigned this Feb 8, 2022
@catherineluse
Copy link
Contributor Author

I have signed the CLA

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @catherineluse! I made a small change to how the hyperlink works, as we use internal references rather than webpage links.

@darrellwarde darrellwarde merged commit bcd1ed5 into neo4j:master Feb 9, 2022
@darrellwarde darrellwarde moved this from High Priority (Community) to Done in PR Triage Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants