Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for priority classes (4.4) #1

Closed
wants to merge 1 commit into from
Closed

Adds support for priority classes (4.4) #1

wants to merge 1 commit into from

Conversation

SansGuidon
Copy link

@SansGuidon
Copy link
Author

Hi @harshitsinghvi22 , is it possible to get news about the support of priority classes for this release as this PR gets closed ?

@harshitsinghvi22
Copy link
Collaborator

Hi @MorganGeek ,

Apologies for accidentally closing your pull request.

The initial repo has been getting synced from our private repo and now we have made a decision to make the repo public completely and have stopped the sync job.

This required us to do a clean slate of the git repo and mirror it from our private repo. While doing the same your pull request got closed.

I have reopened it however it would be great if you can create a feature request under Github issues.

I know how it feels when the pull request gets closed without any explanation.
Once again , Apologies for the inconvenience caused.

Appreciate your time and effort in creating this PR.

Thanks,
Harshit

@SansGuidon
Copy link
Author

Thank you for your feedback, @harshitsinghvi22 , it's much appreciated :-)
I'll add a feature request then :-) , should I then submit my PR linked to this feature request or just wait ?

@harshitsinghvi22
Copy link
Collaborator

@MorganGeek just a feature request will be helpful

@SansGuidon
Copy link
Author

Thank you @harshitsinghvi22 : #15

org-ci-cd referenced this pull request in org-ci-cd/helm-charts Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants