-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS theme changes #1122
CSS theme changes #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at the actual visuals yet, just commenting on the code so far, and you need to remove a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic change, the revised dark theme is beautiful!
Just a few things I found that could be improved.
Statusbar left padding on some frames (same with :sysinfo
) + code/pre field.
I think code blocks should be colored in some way to distinguish them from regular text. Goes for both light and dark theme.
And the overflow on top of statusbar looks strange.
And btw, can you add a few screenshots to the PR description as well, for others to see, that'd be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some small changes (fix failing tests, relationship text color, removal of comments.
This looks very good, thanks for the hard work on this!
Feel free to merge when the tests have gone green.
changelog: Update the UI color schemes (dark, light, contrast)
Example: