Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS theme changes #1122

Merged
merged 7 commits into from
Jun 23, 2020
Merged

CSS theme changes #1122

merged 7 commits into from
Jun 23, 2020

Conversation

shkirando
Copy link
Collaborator

@shkirando shkirando commented Jun 16, 2020

changelog: Update the UI color schemes (dark, light, contrast)

Example:

Screenshot 2020-06-23 14 37 52

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the actual visuals yet, just commenting on the code so far, and you need to remove a few comments.

src/browser/modules/Carousel/style.less Outdated Show resolved Hide resolved
src/browser/modules/Carousel/style.less Outdated Show resolved Hide resolved
src/browser/modules/D3Visualization/components/styled.jsx Outdated Show resolved Hide resolved
src/browser/modules/D3Visualization/components/styled.jsx Outdated Show resolved Hide resolved
src/browser/modules/Editor/styled.jsx Outdated Show resolved Hide resolved
src/browser/modules/Editor/styled.jsx Outdated Show resolved Hide resolved
src/browser/modules/Stream/auto-exec-button.jsx Outdated Show resolved Hide resolved
src/browser/modules/Stream/styled.jsx Outdated Show resolved Hide resolved
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic change, the revised dark theme is beautiful!

Just a few things I found that could be improved.

Eye icon:
Screenshot 2020-06-17 10 56 25

Row separator is hard to see.
Screenshot 2020-06-17 10 50 38

Statusbar left padding on some frames (same with :sysinfo) + code/pre field.
Screenshot 2020-06-17 10 43 33

I think code blocks should be colored in some way to distinguish them from regular text. Goes for both light and dark theme.
And the overflow on top of statusbar looks strange.
Screenshot 2020-06-17 10 42 17

And btw, can you add a few screenshots to the PR description as well, for others to see, that'd be great.

src/browser/components/TabNavigation/styled.jsx Outdated Show resolved Hide resolved
src/browser/components/TabNavigation/styled.jsx Outdated Show resolved Hide resolved
@oskarhane oskarhane self-requested a review June 23, 2020 12:32
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some small changes (fix failing tests, relationship text color, removal of comments.
This looks very good, thanks for the hard work on this!

Feel free to merge when the tests have gone green.

@shkirando shkirando merged commit 2ce5356 into neo4j:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants