Do not store connection passwords in local storage before receiving neo4j config #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edentials is true
jk05
reviewed
Oct 16, 2020
| @@ -18,13 +18,15 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| import { dehydrate } from 'services/duckUtils' | |||
There was a problem hiding this comment.
The matching hydrate code that adds a flag on redux states is never called in current version, so it should be safe to never call dehydrate to remove the flag. As far as I can see, it is safe to remove the hydrate/dehydrate functions completely, they seem to only be used in their test cases. But I left them in this PR to not have a large diff to review.
oskarhane
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passwords are temporarily stored in local storage between connecting and receiving the config even if the
browser.retain_connection_credentialsneo4j config flag is false. To avoid storing passwords in localstorage unless the config flag is true, this PR changes three things: