Update connection form to better reflect aura usage #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview at http://aura_form-neo4j-browser.surge.sh |
oskarhane
reviewed
Oct 29, 2020
OskarDamkjaer
force-pushed
the
aura_form
branch
from
5aec922
to
e311806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test add "localhost" to the NEO4J_CLOUD_DOMAINS in settings duck. I'm unsure how to properly mock the discovery though. I've also tested connecting with the form against a proper aura db.
Form is simplified to show the following:
Unsure if we want to keep the dropdown when we only have one option. I've also considered adding a pattern to the form to require the connection url match the format of the required scheme. Thoughts?
Also. Aura calls it "Connection URI" and we call it a "Connect URL". Should either change to be more consistent?